[FIX] JobsTrap perform_enqueued_jobs not working with jobs creating new jobs (issue OCA#651)
#652
Conversation
fd-oncodna
changed the title
JobsTrap perform_enqueued_jobs not working with jobs creating new jobs (issue OCA#651)
|
Hi @guewen, |
queue_job/tests/common.py
Outdated
| @@ -227,13 +227,13 @@ def perform_enqueued_jobs(self): | |||
| def by_graph(job): | |||
| return job.graph_uuid or "" | |||
|
|
|||
| sorted_jobs = sorted(self.enqueued_jobs, key=by_graph) | |||
| sorted_jobs = sorted(self.enqueued_jobs[:], key=by_graph) | |||
There was a problem hiding this comment.
I don't believe the extra [:] slicing here is necessary.
There was a problem hiding this comment.
I agree, since sorted returns already a new list.
queue_job/tests/common.py
Outdated
| @@ -227,13 +227,13 @@ def perform_enqueued_jobs(self): | |||
| def by_graph(job): | |||
| return job.graph_uuid or "" | |||
|
|
|||
| sorted_jobs = sorted(self.enqueued_jobs, key=by_graph) | |||
| sorted_jobs = sorted(self.enqueued_jobs[:], key=by_graph) | |||
There was a problem hiding this comment.
I agree, since sorted returns already a new list.
|
@simahawk everything's done ;) |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@fd-oncodna tnx, any chance you can backoprt this to 15 and 16? |
|
Congratulations, your PR was merged at 20d3436. Thanks a lot for contributing to OCA. ❤️ |
|
JobsTrapperform_enqueued_jobsnot working with jobs creating new jobs. After a call toJobsTrap.perform_enqueued_jobstheenqueued_jobsattribute is empty, even if one of the jobs executed had the effect of creating new jobs. That is because after executing the jobs of the queue in a loop,JobsTrap.perform_enqueued_jobssets theenqueued_jobsto[]ignoring the newly created jobs.