-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] project_timeline: Migration to 15.0 #942
Conversation
/ocabot migration project_timeline |
5a5d406
to
7b3bbc2
Compare
Deppends on OCA/web#2247 |
<div class="o_project_timeline_item"> | ||
<img | ||
t-if="record.user_ids" | ||
t-attf-src="/web/image/res.users/#{record.user_ids[0][0]}/image_128/16x16" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to change to user_ids[0] to give ID or no image displayed:
t-attf-src="/web/image/res.users/#{record.user_ids[0]}/image_128/16x16"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can display all user_ids images with this:
<t t-foreach="record.user_ids" t-as="user_id"> <img t-attf-src="/web/image/res.users/#{user_id}/image_128/16x16" width="16" height="16" class="mr8" alt="User" /> </t>
<img | ||
t-if="record.user_ids" | ||
t-attf-src="/web/image/res.users/#{record.user_ids[0][0]}/image_128/16x16" | ||
t-att-title="record.user_ids[0][1]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed t-att-title as not working (user_ids is only a list of IDs apparently)
535046c
to
b304f9c
Compare
default_group_by="project_id" | ||
event_open_popup="true" | ||
colors="white: user_ids == []; #2ecb71: kanban_state == 'done'; #ec7063: kanban_state == 'blocked'" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing as V15 now has task dependency built-in, could I suggest we add the following to put the arrows on tasks that use this feature:
colors="white: user_ids == []; #2ecb71: kanban_state == 'done'; #ec7063: kanban_state == 'blocked'"
dependency_arrow="depend_on_ids"
>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah appreciate that, but thought we could deprecate project_task_dependency and project_timeline_task_dependency in favour of they now achieve the same in 15.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't know about the extra modules to add this. Added the feature 😄
Please rebase and push for forcing the rebuild. |
========================== Timeline view for projects ========================== This module extends the standard tasks actions to add the timeline view to them, and also adds the needed fields in the view for handling them. Usage ===== * Go to *Project > Project > Tasks*. * Click on the icon with a clock. * You will see the tasks in the new view.
* [IMP] Add start and end date in task form view * [IMP] Add start and end date in task form view
Currently, if `date_end` is not set it will result in a KeyError.
…_state : blocked tasks are red and task without user are white [IMP] project_timeline : planned_hours is displayed only if not null
Modules that bring `gantt` and `map` view mode are not declared in module dependency Those modes were introduced by https://github.com/OCA/project/pull/869/files#r785447743
b304f9c
to
3d0ee7e
Compare
Done @pedrobaeza |
I don't have this traceback locally, seems like an issue with runboat. I tried to reset the runboat build. |
Hello @chrisandrewmann |
@jguenat I don't see them myself either, I tested on a local instance and have also deployed to my production system. |
Sorry, the concerns were already fixed: /ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
/ocabot migration project_timeline |
Congratulations, your PR was merged at b3767fe. Thanks a lot for contributing to OCA. ❤️ |
@Tecnativa TT37717