Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG][project_task_stage_state] Standard migration to project_task_stage_state #916

Merged
merged 29 commits into from
May 7, 2022

Conversation

manuelregidor
Copy link

Standard migration.

dreispt and others added 28 commits April 25, 2022 13:36
Currently translated at 100,0% (8 of 8 strings)

Translation: project-11.0/project-11.0-project_stage_state
Translate-URL: https://translation.odoo-community.org/projects/project-11-0/project-11-0-project_stage_state/fr/
Currently translated at 100.0% (8 of 8 strings)

Translation: project-12.0/project-12.0-project_stage_state
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_stage_state/gl/
Currently translated at 100.0% (8 of 8 strings)

Translation: project-12.0/project-12.0-project_stage_state
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_stage_state/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-13.0/project-13.0-project_stage_state
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_stage_state/
Currently translated at 100.0% (11 of 11 strings)

Translation: project-14.0/project-14.0-project_stage_state
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_stage_state/es_AR/
Currently translated at 100.0% (8 of 8 strings)

Translation: project-14.0/project-14.0-project_stage_state
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_stage_state/fr/
Currently translated at 72.7% (8 of 11 strings)

Translation: project-14.0/project-14.0-project_stage_state
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_stage_state/fr_FR/
@manuelregidor
Copy link
Author

Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreispt ? 😄 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Sponsor Member

dreispt commented Apr 30, 2022

This looks great, but shouldn't it have a migration script?

@manuelregidor
Copy link
Author

This looks great, but shouldn't it have a migration script?

Hi @dreispt What do you think the migration script should do? I could add it to the PR. Thank you.

@dreispt
Copy link
Sponsor Member

dreispt commented May 6, 2022

@manuelregidor Maybe no needed if it is only a module name change, with no impact in the actual database.

@HaraldPanten
Copy link

HaraldPanten commented May 6, 2022

@dreispt the functionallity is not changing. Just the name. We'll need to include this change to the apriori.py document only.

Could you merge @rafaelbn ?

@dreispt
Copy link
Sponsor Member

dreispt commented May 6, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-916-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 6, 2022
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-916-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@HaraldPanten
Copy link

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-916-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

A temporary issue, maybe?

@rafaelbn
Copy link
Member

rafaelbn commented May 7, 2022

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-916-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 84378a8 into OCA:15.0 May 7, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 723ab30. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten
Copy link

/ocabot merge patch

THX!

@HaraldPanten HaraldPanten deleted the 15.0-mig-project_stage_state branch May 7, 2022 13:37
@ao-landoo

This comment was marked as resolved.

@rafaelbn
Copy link
Member

@rafaelbn rafaelbn changed the title [15.0][MIG][project_stage_state] [15.0][MIG][project_stage_state] Standard migration to project_task_stage_state Oct 18, 2022
@dreispt dreispt changed the title [15.0][MIG][project_stage_state] Standard migration to project_task_stage_state [15.0][MIG][project_task_stage_state] Standard migration to project_task_stage_state Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.