Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] project_task_dependency: migration #892

Merged
merged 47 commits into from
Mar 22, 2022
Merged

[15.0][MIG] project_task_dependency: migration #892

merged 47 commits into from
Mar 22, 2022

Conversation

Mantux11
Copy link

@Mantux11 Mantux11 commented Feb 4, 2022

There is only migration script to save old data. For now one Odoo 15 has dependencies, so this module is not longer needed.

Dennis Sluijk and others added 30 commits February 4, 2022 07:47
@Mantux11
[10.0][ADD][project_task_dependency] Task dependencies on tasks (#202)
249fc9b 
* [ADD] project_task_dependencies

[FIX] Removed bullet point

* [FIX] Module name and circular depedencies

* [FIX] NewId issue

* [FIX] Test names
@astirpe @Mantux11
[FIX] mutual dependency avoid recursion
2ca3df4
@oca-transbot @Mantux11
OCA Transbot updated translations from Transifex
8257614
@PCatinean @Mantux11
[MIG] project_task_dependency: Migration to 11.0
a0e728d
@PCatinean @Mantux11
[FIX] Fix dependency recursion error due to upstream changes in odoo
84e49c2
@oca-travis @Mantux11
[UPD] Update project_task_dependency.pot
ed34b99
@didierdonze @Mantux11
Translated using Weblate (French) [ci skip]
68654d7 
Currently translated at 100.0% (8 of 8 strings)

Translation: project-11.0/project-11.0-project_task_dependency
Translate-URL: https://translation.odoo-community.org/projects/project-11-0/project-11-0-project_task_dependency/fr/
@Mantux11
Translated using Weblate (Português (Brasil))
07db637 
Currently translated at 100,0% (8 of 8 strings)

Translation: project-11.0/project-11.0-project_task_dependency
Translate-URL: https://translation.odoo-community.org/projects/project-11-0/project-11-0-project_task_dependency/pt_BR/
@SalahAdDin @Mantux11
Update tr.po
a78d739
@tarteo @Mantux11
[11.0][FIX] Copying dependencies in project_task_dependency (#425)
f82091a
@oca-travis @Mantux11
[UPD] Update project_task_dependency.pot
2ee39ff
@oca-transbot @Mantux11
Update translation files
9902c45 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@pedrobaeza @Mantux11
[IMP] project_task_dependency: Improve performance on task form
12ac773 
Depending tasks are very expensive to be computed, so we remove them
from the form view as they are useless.

We need also to split the compute method for each field for not suffering the
same problem with the needed field. Any way, this doesn't add anything, as
each field is computed isolatedly.

Finally, a bit of tweaking has been done for improving a bit computation of
dependencies.
@oca-travis @Mantux11
[UPD] Update project_task_dependency.pot
0017193
@oca-transbot @Mantux11
Update translation files
681e54d 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@AdriaGForgeFlow @Mantux11
[MIG] Migrate module project_task_dependency to v12.0
f21a8ec
@OCA-git-bot @Mantux11
[UPD] README.rst
fff9a64
@oca-travis @Mantux11
[UPD] Update project_task_dependency.pot
cb7cfc1
@oca-transbot @Mantux11
Update translation files
2850378 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-12.0/project-12.0-project_task_dependency
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_dependency/
@mvrodriguez @Mantux11
Translated using Weblate (Galician)
7c31913 
Currently translated at 100.0% (19 of 19 strings)

Translation: project-12.0/project-12.0-project_task_dependency
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_dependency/gl/
@mvrodriguez @Mantux11
Translated using Weblate (Spanish)
ff50931 
Currently translated at 100.0% (19 of 19 strings)

Translation: project-12.0/project-12.0-project_task_dependency
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_dependency/es/
@benbrich @Mantux11
Translated using Weblate (German)
fe91700 
Currently translated at 100.0% (19 of 19 strings)

Translation: project-12.0/project-12.0-project_task_dependency
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_dependency/de/
@OCA-git-bot @Mantux11
[ADD] icon.png
a643862
@tbaden @Mantux11
[FIX][12.0] project_task_dependency missing newline
e9470b8
@OCA-git-bot @Mantux11
[UPD] README.rst
13ebd87
@sysadminmatmoz @Mantux11
Translated using Weblate (Slovenian)
8337073 
Currently translated at 100.0% (19 of 19 strings)

Translation: project-12.0/project-12.0-project_task_dependency
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_dependency/sl/
@oca-travis @Mantux11
[UPD] Update project_task_dependency.pot
0d7666b
@oca-transbot @Mantux11
Update translation files
dcc8165 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-12.0/project-12.0-project_task_dependency
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_dependency/
@badbole @Mantux11
Translated using Weblate (Croatian)
5d5c260 
Currently translated at 100.0% (19 of 19 strings)

Translation: project-12.0/project-12.0-project_task_dependency
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_dependency/hr/
@gregory-moka @Mantux11
Translated using Weblate (French)
c2d83dd 
Currently translated at 78.9% (15 of 19 strings)

Translation: project-12.0/project-12.0-project_task_dependency
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_dependency/fr/
@BT-aestebanez
Copy link

Yes, you are right
However.. @Mantux11 could you include this query?

@Mantux11
[15.0][MIG] project_task_dependency: deleted module
cb7aeab 
and added migration scripts. Odoo 15 for now have their own
dependencies.
@Mantux11
Copy link
Author

Good point here. I haven't thinked about that. @BT-aestebanez I have included your query.

BT-aestebanez
BT-aestebanez approved these changes Feb 21, 2022
View reviewed changes
Copy link

@BT-aestebanez BT-aestebanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ghost
Copy link

ghost commented Feb 25, 2022

@dreispt @AaronHForgeFlow can you please merge this PR? Thank you

@BT-aestebanez
Copy link

@rafaelbn Could you please review (and merge if you find it correct) this PR?

@rafaelbn
Copy link
Member

rafaelbn commented Mar 7, 2022

Hello @astirpe , what do you think as maintainer? Thanks in advance 😄

@rafaelbn
Copy link
Member

rafaelbn commented Mar 7, 2022

/ocabot migration project_task_dependency

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Mar 7, 2022
@BT-aestebanez
Copy link

@rafaelbn it seems @astirpe does not have time. But @pedrobaeza said the approach was ok... I think we can merge it, don't you?

@dreispt
Copy link
Sponsor Member

dreispt commented Mar 21, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-892-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 21, 2022
@OCA-git-bot
Merge PR #892 into 15.0
f257008 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-892-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@BT-aestebanez
Copy link

@dreispt Thanks.
This is the error message:
Error: reserveCache failed: Cache already exists. Scope: refs/heads/15.0-ocabot-merge-pr-892-by-dreispt-bump-nobump, Key: pre-commit-2-e233dd2121e64c861dfc8efd42bc49a71b455d4b158f53eb6973b5ed6703f473-6f934adb923502b30b518d023467313f206d1f64d803d89596ae85986792faeb, Version: 28cdb9f5496f334116f23e86f0063f5d3a9348c2e22425a33171e071aadada7e
that prevents to merge

@dreispt
Copy link
Sponsor Member

dreispt commented Mar 22, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-892-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c43304b into OCA:15.0 Mar 22, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 08e565c. Thanks a lot for contributing to OCA. ❤️

@Mantux11 Mantux11 deleted the 15.0-mig-project_task_dependency branch June 13, 2022 12:29
@angelmoya angelmoya mentioned this pull request May 9, 2023
Open
36 tasks
@thomaspaulb thomaspaulb mentioned this pull request Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BT-aestebanez BT-aestebanez BT-aestebanez approved these changes

@gaikaz gaikaz gaikaz approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.