-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][ADD] project_task_milestone: added module #888
[15.0][ADD] project_task_milestone: added module #888
Conversation
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-888-by-gurneyalex-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@Mantux11 @gurneyalex can we get this PR merged? Can I help somehow? Tests run without issues locally. |
@yankinmax I couldn't see what's wrong with merging. I see that only |
@Mantux11 yep, exactly! For me the same! |
@davejames Hey. I saw that you migrated |
@gurneyalex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
@Mantux11 I can't really perform functional test, runboat is missing - maybe try to rebase onto 15.0 again and push? |
@alexey-pelykh Done. Now runboat is accessible. |
This PR has the |
@alexey-pelykh Can you test and merge that? Later runboat would be inactive again. Thanks :) |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 6669a71. Thanks a lot for contributing to OCA. ❤️ |
Added new module
project_task_milestone
. In odoo 15,project_milestone
is by default. So this module would linkproject_task
withproject_milestone
models.IMPORTANT:
Migration to 15.0
project_milestone
, migration scripts would be needed by migratingproject_milestone
module. I'll do that later.Discussion was here: discussion.