Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] project_task_milestone: added module #888

Merged
merged 1 commit into from
Jun 30, 2022
Merged

[15.0][ADD] project_task_milestone: added module #888

merged 1 commit into from
Jun 30, 2022

Conversation

Mantux11
Copy link

Added new module project_task_milestone. In odoo 15, project_milestone is by default. So this module would link project_task with project_milestone models.

IMPORTANT:

Migration to 15.0 project_milestone, migration scripts would be needed by migrating project_milestone module. I'll do that later.

Discussion was here: discussion.

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-888-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 16, 2022
Signed-off-by gurneyalex
@OCA-git-bot
Copy link
Contributor

@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-888-by-gurneyalex-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@yankinmax
Copy link

@Mantux11 @gurneyalex can we get this PR merged? Can I help somehow? Tests run without issues locally.

@Mantux11
Copy link
Author

@yankinmax I couldn't see what's wrong with merging. I see that only codecov shows the error's and also here in PR, all checks has been successful except for runbot that it's not used anymore because of runboat. So I can't find where is the problem.

@yankinmax
Copy link

@Mantux11 yep, exactly! For me the same!
@gurneyalex could we somehow bypass runbot to merge this PR?

@Mantux11
Copy link
Author

@davejames Hey. I saw that you migrated project_milestone module, because of that, I wanted your approve and want to "move" this and also project_milestone PR. Could you do that?

@Du-ma
Copy link
Member

Du-ma commented Jun 23, 2022

@gurneyalex
Yo, can we merge this?

@alexey-pelykh alexey-pelykh changed the title [ADD] project_task_milestone: added module [15.0][ADD] project_task_milestone: added module Jun 27, 2022
Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@alexey-pelykh
Copy link
Contributor

@Mantux11 I can't really perform functional test, runboat is missing - maybe try to rebase onto 15.0 again and push?

@Mantux11
Copy link
Author

@alexey-pelykh Done. Now runboat is accessible.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Mantux11
Copy link
Author

@alexey-pelykh Can you test and merge that? Later runboat would be inactive again. Thanks :)

@alexey-pelykh
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-888-by-alexey-pelykh-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 01e212b into OCA:15.0 Jun 30, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6669a71. Thanks a lot for contributing to OCA. ❤️

@Mantux11 Mantux11 deleted the 15.0-add-project_task_milestone branch July 1, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants