Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] project_duplicate_subtask #867

Merged
merged 9 commits into from
Jul 6, 2022

Conversation

mariadforgeflow
Copy link

@mariadforgeflow mariadforgeflow commented Dec 14, 2021

Standard Migration to v15.
Child tasks of subtasks weren't duplicated: added recursive function that runs through all the children duplicating them as well.

@ForgeFlow

Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally. Only comment I have is when I duplicate a record the normal way it updates the javascript model with the new record, and opens the record in edit mode.
With 'Duplicate with subtasks' it's different.

Before:
image

After normal duplicate:
image

After "Duplicate with subtasks":

image

But for me this is small ux issue, not that important

@sbidoul
Copy link
Member

sbidoul commented Jan 25, 2022

/ocabot migration project_duplicate_subtask

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 25, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 25, 2022
32 tasks
@mariadforgeflow
Copy link
Author

Hi @tarteo! I have updated the PR. After duplicate a task it opens the new record in edit mode, the js issue I don't know how to fix it.
Also, I noticed that child tasks of subtasks weren't duplicated, now there is a recursive function that runs through all the children duplicating them as well.
If you could check it now with this changes I would appreciate it a lot. Thanks!

Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@dreispt
Copy link
Sponsor Member

dreispt commented Feb 6, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-867-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 6, 2022
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-867-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@mariadforgeflow
Copy link
Author

@dreispt hi!! Could you try to merge it again please? thx!

@dreispt
Copy link
Sponsor Member

dreispt commented Feb 24, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-867-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 24, 2022
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-867-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@AaronHForgeFlow
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-867-by-AaronHForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 2, 2022
Signed-off-by AaronHForgeFlow
@OCA-git-bot
Copy link
Contributor

@AaronHForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-867-by-AaronHForgeFlow-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@mariadforgeflow mariadforgeflow force-pushed the 15-mig-project_duplicate_subtask branch from faad95c to 3a81866 Compare April 1, 2022 08:49
@MiquelRForgeFlow
Copy link

Now with github actions I think it won't give silly errors. @dreispt @tarteo could you merge?

@leemannd
Copy link

leemannd commented Jul 6, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-867-by-leemannd-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@leemannd The merge process could not be finalized, because command git push origin 15.0-ocabot-merge-pr-867-by-leemannd-bump-nobump:15.0 failed with output:

To https://github.com/OCA/project
 ! [rejected]          15.0-ocabot-merge-pr-867-by-leemannd-bump-nobump -> 15.0 (fetch first)
error: failed to push some refs to 'https://***@github.com/OCA/project'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@OCA-git-bot OCA-git-bot merged commit 0b4ed2b into OCA:15.0 Jul 6, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ff09ee1. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 15-mig-project_duplicate_subtask branch July 6, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.