-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] project_duplicate_subtask #867
[15.0][MIG] project_duplicate_subtask #867
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally. Only comment I have is when I duplicate a record the normal way it updates the javascript model with the new record, and opens the record in edit mode.
With 'Duplicate with subtasks' it's different.
After "Duplicate with subtasks":
But for me this is small ux issue, not that important
/ocabot migration project_duplicate_subtask |
db312da
to
ee47814
Compare
Hi @tarteo! I have updated the PR. After duplicate a task it opens the new record in edit mode, the js issue I don't know how to fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-867-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@dreispt hi!! Could you try to merge it again please? thx! |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-867-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
ee47814
to
faad95c
Compare
/ocabot merge nobump |
On my way to merge this fine PR! |
@AaronHForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-867-by-AaronHForgeFlow-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
version conflict prevents upload to pypi
faad95c
to
3a81866
Compare
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
@leemannd The merge process could not be finalized, because command
|
Congratulations, your PR was merged at ff09ee1. Thanks a lot for contributing to OCA. ❤️ |
Standard Migration to v15.
Child tasks of subtasks weren't duplicated: added recursive function that runs through all the children duplicating them as well.
@ForgeFlow