Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] project_wbs: Manager consistency between project and analytic account #1226

Merged
merged 1 commit into from
May 3, 2024
Merged

[14.0][FIX] project_wbs: Manager consistency between project and analytic account #1226

merged 1 commit into from
May 3, 2024

Conversation

AaronHForgeFlow
Copy link

Steps to reproduce:

  • Create a project and put a Project Manager
  • Change the Project Manager in the Project
  • The Project Manager in the analytic account is not changed

Expected behavior: the Project Manager in the analytic account is the same as in the project. Project Manager is the manager of the project hierarchy.

The "Manager" field is the manager of a individual child project and the consistency in ensured because is a related field.

cc @ForgeFlow

@AaronHForgeFlow AaronHForgeFlow mentioned this pull request Jan 29, 2024
Merged
LoisRForgeFlow
LoisRForgeFlow approved these changes Feb 5, 2024
View reviewed changes
Copy link

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreispt
Copy link
Sponsor Member

dreispt commented Apr 27, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1226-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 27, 2024
@OCA-git-bot
Merge PR #1226 into 14.0
3106538 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1226-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@AaronHForgeFlow
Copy link
Author

checked the logs, I think we can try again the merge command

@dreispt
Copy link
Sponsor Member

dreispt commented Apr 29, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1226-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 29, 2024
@OCA-git-bot
Merge PR #1226 into 14.0
60ecb15 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1226-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

1 similar comment
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1226-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@AaronHForgeFlow AaronHForgeFlow mentioned this pull request Apr 30, 2024
Closed
@AaronHForgeFlow AaronHForgeFlow force-pushed the 14.0-fix-project_wbs-manager branch 2 times, most recently from efa7c1d to 8b60bf8 Compare May 3, 2024 07:31
@AaronHForgeFlow
Copy link
Author

@dreispt I rebased the branch again and now the CI jobs run correctly :)

Can you please try again? Thank you!

@dreispt
Copy link
Sponsor Member

dreispt commented May 3, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1226-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c01078a into OCA:14.0 May 3, 2024
7 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8b00aa4. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 14.0-fix-project_wbs-manager branch May 3, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreispt dreispt dreispt approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AaronHForgeFlow @dreispt @OCA-git-bot @LoisRForgeFlow