Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][15.0][MIG]project_gtd: Migration to 15.0 #1080

Closed

Conversation

bizzappdev
Copy link

No description provided.

sebalix and others added 30 commits March 5, 2023 03:19
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
Currently translated at 93.0% (40 of 43 strings)

Translation: project-10.0/project-10.0-project_gtd
Translate-URL: https://translation.odoo-community.org/projects/project-10-0/project-10-0-project_gtd/nl/
Currently translated at 97.7% (42 of 43 strings)

Translation: project-10.0/project-10.0-project_gtd
Translate-URL: https://translation.odoo-community.org/projects/project-10-0/project-10-0-project_gtd/de/
Currently translated at 100.0% (43 of 43 strings)

Translation: project-10.0/project-10.0-project_gtd
Translate-URL: https://translation.odoo-community.org/projects/project-10-0/project-10-0-project_gtd/de/
Currently translated at 100.0% (43 of 43 strings)

Translation: project-14.0/project-14.0-project_gtd
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_gtd/es_AR/
@pedrobaeza
Copy link
Member

/ocabot migration project_gtd

@bizzappdev thanks for this massive migration pull requests wave. Unfortunately, the pull request is only the first step of the OCA workflow. As you may know, there should be 2 reviews and one for a PSC/maintainer for merging them. Maybe you can do cross reviews for asking other contributors to review your PRs, or inside your team, do as well cross-reviews. The problem is that if you put everything under the same GitHub login, it's not possible technically nor trustable. Do you think there can be any solution?

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Mar 5, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 5, 2023
32 tasks
@bizzappdev
Copy link
Author

bizzappdev commented Mar 6, 2023

@pedrobaeza thank you for taking care of updating all PRS.
We are also planning to do the Review by the team soon.

I like to differ for if everything is from one account "it's not possible technically nor trustable"
technically we did an internal code sprint in December and after that every now and then whoever was free they were checking and fixing things or testing the migrated code. once it is ready we do a code review internally and check the quality for the same and then testing of the functionality after that only we create PR on the OCA.
We have chosen this because this will give flexibility to us and we can also have a watch over the quality.
Also, not everyone is checking the progress or do communicate on the PR. so from one account I can at least do the communication and keep watch over the changes or updates.

let me know if this does not fall into the technical or trustable part. we will try to limit the PR creation from one account.

@pedrobaeza
Copy link
Member

We can do the same using an organization (Tecnativa), but pushing from individual commits.

The technical part is that from the same account that you do the PR, you can't make a review (try it and tell me). The trustable part is that if anybody sees an approval from the same account, how do they know that is a second person who is reviewing it instead the same one?

@github-actions
Copy link

github-actions bot commented Aug 6, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 6, 2023
@github-actions github-actions bot closed this Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.