Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] pos_customer_tree_view_vat: Migration to 16.0 #1221

Merged
merged 7 commits into from
Aug 20, 2024
Merged

[16.0][MIG] pos_customer_tree_view_vat: Migration to 16.0 #1221

merged 7 commits into from
Aug 20, 2024

Conversation

chienandalu
Copy link
Member

Standard migration

cc @Tecnativa TT49799

please review @CarlosRoca13 @pilarvargas-tecnativa

CarlosRoca13
CarlosRoca13 approved these changes Jul 17, 2024
View reviewed changes
Copy link

@CarlosRoca13 CarlosRoca13 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a non-blocking comment

I think that the extensions should be defined in separated files and charged just after the main module to avoid loosing it if some other module make a primary template of it.

pos_customer_tree_view_vat/static/src/xml/pos.xml Outdated Show resolved Hide resolved
pos_customer_tree_view_vat/__manifest__.py Outdated Show resolved Hide resolved
@chienandalu chienandalu force-pushed the 16.0-mig-pos_customer_tree_view_vat branch from dc55398 to b75fe3b Compare July 17, 2024 06:29
@chienandalu
Copy link
Member Author

@CarlosRoca13 changes done. Thanks for the tips :)

CarlosRoca13
CarlosRoca13 approved these changes Jul 17, 2024
View reviewed changes
Copy link

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😄

@pedrobaeza
Copy link
Member

/ocabot migration pos_customer_tree_view_vat

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 17, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 17, 2024
Open
37 tasks
pilarvargas-tecnativa
pilarvargas-tecnativa reviewed Jul 17, 2024
View reviewed changes
Copy link

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza
pedrobaeza approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1221-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6807c57 into OCA:16.0 Aug 20, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 41107ea. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-pos_customer_tree_view_vat branch August 20, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

@pilarvargas-tecnativa pilarvargas-tecnativa pilarvargas-tecnativa approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@chienandalu @pedrobaeza @OCA-git-bot @CarlosRoca13 @pilarvargas-tecnativa @mileo @mymage @francesco-ooops @Ivorra78