Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] base_location_geonames_import: manually add zip files to folder #1841

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

Tisho99
Copy link

@Tisho99 Tisho99 commented Sep 5, 2024

In geonames, there are some countries that do not have a zip list to be downloaded. For example Greece (GR) or Cayman Islands (CY).

This PR adds those files to a new folder of the base_location_geonames_import module. If the list of zips of a country can not be downloaded in Geonames, Odoo will search for the file locally.

T-5767

@Tisho99 Tisho99 changed the title [IMP] base_location_geonames_import: add posibility to manually add y… [IMP] base_location_geonames_import: manually add zip files to folder Sep 5, 2024
@Tisho99 Tisho99 force-pushed the 16.0-imp-base_location_geonames_import branch 4 times, most recently from 2f8ebbb to 5475431 Compare September 9, 2024 09:31
@Tisho99 Tisho99 marked this pull request as ready for review September 9, 2024 09:36
@Tisho99
Copy link
Author

Tisho99 commented Sep 9, 2024

Copy link

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: LGTM 👍🏻

Copy link
Contributor

@manuelregidor manuelregidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants