-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] base_location_geonames_import: manually add zip files to folder #1841
Open
Tisho99
wants to merge
1
commit into
OCA:16.0
Choose a base branch
from
sygel-technology:16.0-imp-base_location_geonames_import
base: 16.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[IMP] base_location_geonames_import: manually add zip files to folder #1841
Tisho99
wants to merge
1
commit into
OCA:16.0
from
sygel-technology:16.0-imp-base_location_geonames_import
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tisho99
changed the title
[IMP] base_location_geonames_import: add posibility to manually add y…
[IMP] base_location_geonames_import: manually add zip files to folder
Sep 5, 2024
Tisho99
force-pushed
the
16.0-imp-base_location_geonames_import
branch
4 times, most recently
from
September 9, 2024 09:31
2f8ebbb
to
5475431
Compare
luis-ron
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review: LGTM 👍🏻
manuelregidor
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pedrobaeza
requested changes
Sep 13, 2024
Add greece file Add cayman islands file
Tisho99
force-pushed
the
16.0-imp-base_location_geonames_import
branch
from
September 13, 2024 09:35
5475431
to
36db13c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In geonames, there are some countries that do not have a zip list to be downloaded. For example Greece (GR) or Cayman Islands (CY).
This PR adds those files to a new folder of the base_location_geonames_import module. If the list of zips of a country can not be downloaded in Geonames, Odoo will search for the file locally.
T-5767