Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] [MIG] partner_tier_validation: Migration to 17.0 #1818

Open
wants to merge 47 commits into
base: 17.0
Choose a base branch
from

Conversation

rven
Copy link
Contributor

@rven rven commented Jul 19, 2024

No description provided.

dreispt and others added 30 commits July 19, 2024 14:27
- Added new optional tier definition for is_company = true.
- Added auto active if no validation needed during create.
- Added reset validation during write for specific fields.

[FIX] Code White Space Formatting

[IMP] Reviewer Suggestions

[IMP] Added Tests
Having this rule activated by default in tests environments makes other tests to fail due to the additional constraint not expected by them, so what we are doing is:

- Having the rule deactivated by default.
- On a post-init hook, we activate it only if we are not in a test environment.
- On own modules tests, we activate it as well

TT30292
This prevents a scenario where a user can bypass validation by moving the partner to a 'cancel' stage and then moving it back to confirmed.
oca-ci and others added 15 commits July 19, 2024 14:27
Currently translated at 100.0% (16 of 16 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_tier_validation/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-16.0/partner-contact-16.0-partner_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_tier_validation/
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_tier_validation/es/
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_tier_validation/it/
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_tier_validation/it/
@rven rven mentioned this pull request Jul 22, 2024
63 tasks
@rven rven force-pushed the 17.0-mig-partner_tier_validation branch from b8154df to 4e364e6 Compare September 4, 2024 13:43
@rven rven force-pushed the 17.0-mig-partner_tier_validation branch 3 times, most recently from 3cb28ae to dcc4dd3 Compare September 4, 2024 14:04
Caused by: EvalError: Can not evaluate python expression: (bool(bool(review_ids)))
    Error: Name 'review_ids' is not defined
    EvalError: Can not evaluate python expression: (bool(bool(review_ids)))
    Error: Name 'review_ids' is not defined
@rven rven force-pushed the 17.0-mig-partner_tier_validation branch from dcc4dd3 to 14b66ba Compare September 5, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.