Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MAINTAINER_ROLE_PAGE variable #157

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

tafaRU
Copy link
Member

@tafaRU tafaRU commented Oct 14, 2021

This variable is no longer used after #139

@sbidoul sbidoul merged commit d6dd16c into OCA:master Oct 15, 2021
@sbidoul
Copy link
Member

sbidoul commented Oct 15, 2021

Thanks! Note this part is currently disabled on OCA because it was too noisy (we should not show the message on each PR) and sometimes incorrect (showing the message when the author is already maintainer ?).

@tafaRU tafaRU deleted the rem-maintainer-role-page branch October 15, 2021 16:28
@tafaRU
Copy link
Member Author

tafaRU commented Oct 18, 2021

Note this part is currently disabled on OCA because it was too noisy [-CUT-]

Ok, thanks for pointing this out.

Just out of curiosity: how was this done?

@sbidoul
Copy link
Member

sbidoul commented Oct 18, 2021

@tafaRU
Copy link
Member Author

tafaRU commented Oct 19, 2021

Thanks @sbidoul!

@tafaRU
Copy link
Member Author

tafaRU commented Oct 19, 2021

@sbidoul sorry to bother you again but I didn't understand which part you mean with:

his part is currently disabled on OCA

Looking through last commits I can only see 1e444b6, is it about this?

With reference to https://github.com/OCA/oca-github-bot#id1, the following feature:

Comment with a call for maintainers if there are no declared maintainer.

is still there, right?

@sbidoul
Copy link
Member

sbidoul commented Oct 19, 2021

Yes it's there. But on the oca instance, ADOPT_AN_ADDON_MENTION is not set, so get_adopt_mention returns nothing and therefore it is silent.

@tafaRU
Copy link
Member Author

tafaRU commented Oct 20, 2021

Now I got it 😉 Thanks @sbidoul!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants