Skip to content

aep.py float_is_zero rounding #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Martronic-SA opened this issue Oct 12, 2017 · 1 comment · Fixed by #32
Closed

aep.py float_is_zero rounding #30

Martronic-SA opened this issue Oct 12, 2017 · 1 comment · Fixed by #32
Labels
9.0 10.0 bug

Comments

@Martronic-SA
Copy link
Contributor

Are you sure the following:

float_is_zero(debit-credit,
precision_rounding=self.dp)

is right?
Correct me if I'm wrong but it seems that self.dp which is currency decimal_places is the number of decimals to take, this is an integer like 2 decimals (1.01) and you are passing this in the precision_rounding parameter of float_is_zero.
Shouldn't you use the precision_digits parameters instead?

float_is_zero(debit-credit,
precision_digits=self.dp)
@sbidoul
Copy link
Member

sbidoul commented Oct 12, 2017

Indeed. Well spotted.

@sbidoul sbidoul added this to the 3.0 milestone Oct 12, 2017
sbidoul added a commit to acsone/mis-builder that referenced this issue Oct 12, 2017
@sbidoul
[FIX] float_is_zero issue
b407792 
Fixes OCA#30
@sbidoul sbidoul mentioned this issue Oct 12, 2017
Merged
sbidoul added a commit to acsone/mis-builder that referenced this issue Oct 12, 2017
@sbidoul
[FIX] float_is_zero issue
dd3c13f 
Fixes OCA#30
@sbidoul sbidoul removed this from the Version 3.0 milestone Oct 13, 2017
sbidoul added a commit to acsone/mis-builder that referenced this issue Oct 13, 2017
@sbidoul
[FIX] float_is_zero issue
b45b563 
Fixes OCA#30
sbidoul added a commit to acsone/mis-builder that referenced this issue Oct 13, 2017
@sbidoul
[FIX] float_is_zero issue
b9df3c7 
Fixes OCA#30
JordiBForgeFlow pushed a commit to ForgeFlow/mis-builder that referenced this issue Nov 17, 2017
@sbidoul @JordiBForgeFlow
[FIX] float_is_zero issue
13787e4 
Fixes OCA#30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
9.0 10.0 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue with float_is_zero acsone/mis-builder
2 participants
@sbidoul @Martronic-SA