Skip to content

[17.0][MIG] delivery_gls_asm: Migration to 17.0 #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Dec 31, 2024

Conversation

Tisho99
Copy link
Contributor

@Tisho99 Tisho99 commented Dec 19, 2024

Standard migration

T-7119

david and others added 17 commits December 19, 2024 18:08
[UPD] Update delivery_gls_asm.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-12.0/l10n-spain-12.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-delivery_gls_asm/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-12.0/l10n-spain-12.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-delivery_gls_asm/
Currently translated at 68.4% (93 of 136 strings)

Translation: l10n-spain-12.0/l10n-spain-12.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-delivery_gls_asm/es/
Non implemented methods should raise informative exceptions if used

[UPD] Update delivery_gls_asm.pot

delivery_gls_asm 12.0.1.0.1

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-12.0/l10n-spain-12.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-delivery_gls_asm/
delivery_gls_asm 12.0.1.0.2
The `cliente` key corresponds to the company not to the customer, wich
is `nombre_dst`

delivery_gls_asm 12.0.1.0.3
Alhough it will raise another exception, at least it will show the
proper message and not a traceback.
Ensure that the values sent to the xml soap request are properly
escaped. A partner name like "Johnson & Johnson" would fail otherwise.
[UPD] Update delivery_gls_asm.pot

[UPD] README.rst
Currently translated at 98.5% (135 of 137 strings)

Translation: l10n-spain-13.0/l10n-spain-13.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-13-0/l10n-spain-13-0-delivery_gls_asm/es/
Currently translated at 5.2% (7 of 134 strings)

Translation: l10n-spain-13.0/l10n-spain-13.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-13-0/l10n-spain-13-0-delivery_gls_asm/ca/
Add field for GLS specific states, so the customer can have the same tracking and grouping
on Odoo as they have on the GLS interface
@Tisho99 Tisho99 mentioned this pull request Dec 19, 2024
54 tasks
david and others added 12 commits December 19, 2024 18:22
`res_country.phone_code` is an Integer field, thus it should not be
scaped.

TT33879
GLS ASM API has a limit of 15 characters for its reference so we should
avoid sequences longer than that if we want to avoid collisions.

TT33272

[UPD] Update delivery_gls_asm.pot

delivery_gls_asm 14.0.1.1.1

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-14.0/l10n-spain-14.0-delivery_gls_asm
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-delivery_gls_asm/
Add error codes meaning and rearrange master data in an independent
file.

TT34458
When we deliver to some destinations, the mobile phone and the email
address turn into required fields. We try to fallback to the ones
informed in the commercial entity data.

TT34458

delivery_gls_asm 14.0.1.1.2

[UPD] Update delivery_gls_asm.pot

delivery_gls_asm 14.0.1.2.0

[UPD] Update delivery_gls_asm.pot

delivery_gls_asm 14.0.1.3.0
[UPD] Update delivery_gls_asm.pot
- If the manifest only comes with 1 delivery it is in form of a singular dict instead of a list of dicts and this causes issues when iterating in the XML

delivery_gls_asm 14.0.1.4.1
[UPD] README.rst

delivery_gls_asm 14.0.1.4.2
@Tisho99 Tisho99 force-pushed the 17.0-mig-delivery_gls_asm branch 4 times, most recently from d61c4de to 36f1f56 Compare December 23, 2024 11:49
@Tisho99 Tisho99 marked this pull request as ready for review December 23, 2024 12:12
@Tisho99
Copy link
Contributor Author

Tisho99 commented Dec 23, 2024

@HaraldPanten
Copy link
Contributor

/ocabot migration delivery_gls_asm

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 23, 2024
Copy link

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review: LGTM 👍🏻

@Tisho99 Tisho99 force-pushed the 17.0-mig-delivery_gls_asm branch from 36f1f56 to 0ff8250 Compare December 30, 2024 11:22
@Tisho99 Tisho99 force-pushed the 17.0-mig-delivery_gls_asm branch from 0ff8250 to 716196d Compare December 31, 2024 10:14
Copy link
Contributor

@manuelregidor manuelregidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review. LGTM

Copy link
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-3865-by-pedrobaeza-bump-nobump, awaiting test results.

@ValentinVinagre
Copy link
Contributor

@pedrobaeza La última fusión del año por nuestra parte? 😝

@OCA-git-bot OCA-git-bot merged commit ef0aa95 into OCA:17.0 Dec 31, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1eb6686. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
Copy link
Member

Todavía quedan horas...¿para el SII quizás? jeje

@pedrobaeza pedrobaeza deleted the 17.0-mig-delivery_gls_asm branch December 31, 2024 11:07
@ValentinVinagre
Copy link
Contributor

Todavía quedan horas...¿para el SII quizás? jeje

Ojalá jajaja a ver si para el próximo mes ya conseguimos cerrarlo 😄

@HaraldPanten
Copy link
Contributor

Todavía quedan horas...¿para el SII quizás? jeje

Eso sería un bombazo, lo espero más bien como regalo de Reyes 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.