Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] l10n_es_facturae: required conditions #3854

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Dec 17, 2024

It isn't enough to hide the group containing the fields. For non invoincing addresses we'll end in a blocking situations where we can't save any change.

Bring the behavior from v16

cc @Tecnativa TT52257

please review @pedrobaeza @victoralmau

@OCA-git-bot
Copy link
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza changed the title [FIX] l10n_es_facturae: required conditions [15.0][FIX] l10n_es_facturae: required conditions Dec 17, 2024
@pedrobaeza pedrobaeza added this to the 15.0 milestone Dec 17, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El contacto padre no tiene por qué ser de tipo factura, así como un contacto hijo de tipo factura tampoco tendrá visibles esos campos.

@chienandalu
Copy link
Member Author

Esto es solo para el caso de los hijos, que tienen su propia página <page name="accounting_disabled">. Los datos en el padre se configuran en otro grupo. Algo que sí me pregunto ahora es porqué son obligatorios en el hijo si en el padre no lo son...

@pedrobaeza
Copy link
Member

Ya, pero eso, no deberían ser obligatorios si no se visualizan en el contacto hijo, aunque sea dirección de facturación. ¿Puedes darle una vuelta a todo para dejarlo consistente? Echa un vistazo en 16, que parece estar cubierto.

Bring the behavior from v16

TT52257
@chienandalu chienandalu force-pushed the 15.0-fix-l10n_es_facturae-required-conditions branch from 6b2a574 to cda05f6 Compare December 18, 2024 09:28
@chienandalu
Copy link
Member Author

Cambios hechos trayendo la vista tal cuál está en v16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants