Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] l10n_es_aeat_partner_check: Migration to version 17.0 #3701

Merged
merged 19 commits into from
Sep 12, 2024

Conversation

miquelalzanillas
Copy link
Contributor

New PR for 'l10n_es_aeat_partner_check' migration to 17.0. The previous #3564 has been closed automatically using refork option due a mistake.

@peluko00 @lbarry @mpascuall @carolinafernandez-tecnativa Could you please review?

@miquelalzanillas miquelalzanillas force-pushed the 17.0-mig-l10n_es_aeat_partner_check branch from 595ffd7 to 866c471 Compare August 21, 2024 05:38
@carolinafernandez-tecnativa
Copy link
Contributor

Hi, Could you please squash administrative commits? thanks

@HaraldPanten
Copy link
Contributor

/ocabot migration l10n_es_aeat_partner_check

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 21, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 21, 2024
47 tasks
@miquelalzanillas miquelalzanillas force-pushed the 17.0-mig-l10n_es_aeat_partner_check branch from 866c471 to ec94702 Compare August 21, 2024 11:33
@miquelalzanillas
Copy link
Contributor Author

@carolinafernandez-tecnativa Can you recheck now?

@miquelalzanillas miquelalzanillas force-pushed the 17.0-mig-l10n_es_aeat_partner_check branch from ec94702 to a013965 Compare August 22, 2024 06:07
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks :) @pedrobaeza

README.md Outdated Show resolved Hide resolved
l10n_es_aeat_partner_check/__manifest__.py Outdated Show resolved Hide resolved
l10n_es_aeat_partner_check/tests/test_res_partner.py Outdated Show resolved Hide resolved
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por mi parte algunas cosas de UX nada más. Gracias! ❤️ Gran trabajo!

l10n_es_aeat_partner_check/README.rst Show resolved Hide resolved
Se puede utilizar de forma automática al crear o editar una empresa si
selecciona la opción de "Verificar Información de la Empresa AEAT" o
mediante el botón de "Verificar Información de la Empresa" en la pestaña
AEAT de la empresa.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miquelalzanillas 😄 🙏🏼 por lo que estoy probando en Odoo 17 y en 16 se rompió el form y salen todos los datos descolocados

Mira:

imagen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corregido también.

He dejado el botón centrado y actualizado los estilos.

image

@miquelalzanillas miquelalzanillas force-pushed the 17.0-mig-l10n_es_aeat_partner_check branch 3 times, most recently from 9643579 to b764a6e Compare September 4, 2024 10:11
acysos and others added 15 commits September 4, 2024 12:51
[ADD] l10n_es_aeat: certificates and soap. AEAT Partner check

[ADD] l10n_es_aeat: certificates and soap. AEAT Partner check

[ADD] l10n_es_aeat: certificates and soap. AEAT Partner check

[ADD] l10n_es_aeat: certificates and soap. AEAT Partner check
[ADD] l10n_es_aeat_partner_check: add _parse_aeat_vat_info
Currently translated at 100.0% (23 of 23 strings)

Translation: l10n-spain-12.0/l10n-spain-12.0-l10n_es_aeat_partner_check
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-l10n_es_aeat_partner_check/es/
Currently translated at 95.6% (22 of 23 strings)

Translation: l10n-spain-12.0/l10n-spain-12.0-l10n_es_aeat_partner_check
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-l10n_es_aeat_partner_check/ca/
Añade una petición para comprobar si la empresa está sometido al recargo de equivalencia, indicandolo junto con el resto de la información del pedido
Currently translated at 100.0% (34 of 34 strings)

Translation: l10n-spain-15.0/l10n-spain-15.0-l10n_es_aeat_partner_check
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-15-0/l10n-spain-15-0-l10n_es_aeat_partner_check/ca/
Modificación del string de aeat para evitar la duplicidad del string (p.e. en las vistas search)
OCA-git-bot and others added 3 commits September 4, 2024 12:51
…rtner

Sin esta corrección, los usuarios estaban teniendo este error al escribir en algunos partners:

> No puedes ingresar a los registros 'Certificados AEAT' (l10n.es.aeat.certificate)
>
> Se permite esta operación para los grupos siguientes:
> - Accounting/Advisor
>
> Ponte en contacto con tu administrador para pedirle acceso si es necesario

@moduon MT-2308

Co-authored-by: Loida Vilaplana <[email protected]>
@miquelalzanillas miquelalzanillas force-pushed the 17.0-mig-l10n_es_aeat_partner_check branch from b764a6e to 635dcb4 Compare September 4, 2024 10:54
@miquelalzanillas miquelalzanillas force-pushed the 17.0-mig-l10n_es_aeat_partner_check branch from 635dcb4 to 38f0809 Compare September 4, 2024 11:47
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@miquelalzanillas
Copy link
Contributor Author

Hola @pedrobaeza , parece que no se ha mergeado.

@pedrobaeza
Copy link
Member

El bot de vez en cuando no me hace caso, que lo vuelvo loco, jeje

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-3701-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8920c1f into OCA:17.0 Sep 12, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c6b2298. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.