Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] l10n_es_intrastat_report #3663

Merged
merged 44 commits into from
Nov 20, 2024

Conversation

Josep-s73
Copy link
Contributor

@Josep-s73 Josep-s73 commented Jul 9, 2024

Se ha suprimido el "data/account_fiscal_position_template.xml" del manifest puesto que las posiciones fiscales se definen en el template es_common.

@Josep-s73 Josep-s73 force-pushed the 17.0-mig-l10n_es_intrastat_report branch 12 times, most recently from 523e7f1 to 519feef Compare July 10, 2024 07:13
@hildickethan hildickethan force-pushed the 17.0-mig-l10n_es_intrastat_report branch 6 times, most recently from cdc6371 to ec025fa Compare July 10, 2024 08:22
@Josep-s73 Josep-s73 marked this pull request as ready for review July 10, 2024 08:33
@Josep-s73 Josep-s73 force-pushed the 17.0-mig-l10n_es_intrastat_report branch from ec025fa to a46398f Compare July 10, 2024 08:36
@Josep-s73 Josep-s73 changed the title [17.0][MIG] l10n es intrastat report [17.0][MIG] l10n_es_intrastat_report Jul 10, 2024
@ioans73 ioans73 mentioned this pull request Jul 10, 2024
49 tasks
@etobella
Copy link
Member

/ocabot migration l10n_es_intrastat_report

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 10, 2024
@Josep-s73 Josep-s73 force-pushed the 17.0-mig-l10n_es_intrastat_report branch 6 times, most recently from 9f767e1 to 373bdf3 Compare July 16, 2024 09:06
@sbiosca-s73 sbiosca-s73 force-pushed the 17.0-mig-l10n_es_intrastat_report branch from 7b3dffc to 7101629 Compare November 14, 2024 07:46
@ioans73
Copy link
Member

ioans73 commented Nov 14, 2024

@HaraldPanten podéis comprobar si está correcto ahora?

@HaraldPanten
Copy link
Contributor

@HaraldPanten podéis comprobar si está correcto ahora?

Gracias!

Durante los próximos días hacemos revisión técnica, también 👍

<field name="amount_accessory_cost_company_currency" position="attributes">
<attribute name="invisible">1</attribute>/>
</field>
<field name="amount_accessory_cost_company_currency" invisible="True" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que esta manera de hacer el campo invisible no funciona. ¿No se debería quedar como antes?

<field name="reporting_level" position="attributes">
<attribute name="invisible" />
</field>
<field name="reporting_level" invisible="False" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quizás esto se pueda quitar, ya que reporting_level no es un campo invisible.

@sbiosca-s73 sbiosca-s73 force-pushed the 17.0-mig-l10n_es_intrastat_report branch from 7101629 to e325148 Compare November 19, 2024 07:55
@sbiosca-s73
Copy link

@manuelregidor ya he realizado los cambios que indicas. Gracias!

Copy link
Contributor

@manuelregidor manuelregidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review. LGTM

@HaraldPanten
Copy link
Contributor

@victoralmau Por tu parte cómo lo ves?

@HaraldPanten
Copy link
Contributor

Perfecto, uno menos. Gracias a todos por las contribuciones.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-3663-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0d8e2b5 into OCA:17.0 Nov 20, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3bf825b. Thanks a lot for contributing to OCA. ❤️

@ioans73 ioans73 deleted the 17.0-mig-l10n_es_intrastat_report branch November 20, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.