-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] l10n_es_intrastat_report #3663
[17.0][MIG] l10n_es_intrastat_report #3663
Conversation
523e7f1
to
519feef
Compare
cdc6371
to
ec025fa
Compare
ec025fa
to
a46398f
Compare
/ocabot migration l10n_es_intrastat_report |
9f767e1
to
373bdf3
Compare
…of transaction) TT45420
…mprove test Forgotten changes in OCA@dc2555c required due to change OCA/intrastat-extrastat@7de2169
…ady defined in intrastat_product. Transaction 70 is eliminated, it does not exist (officially). https://eur-lex.europa.eu/legal-content/ES/TXT/HTML/?uri=CELEX:32020R1197&from=EN#d1e32-7-1 company_id=False is not necessary in v16 because the field is no longer has a default
…or when fiscal position is B2C
7b3dffc
to
7101629
Compare
@HaraldPanten podéis comprobar si está correcto ahora? |
Gracias! Durante los próximos días hacemos revisión técnica, también 👍 |
<field name="amount_accessory_cost_company_currency" position="attributes"> | ||
<attribute name="invisible">1</attribute>/> | ||
</field> | ||
<field name="amount_accessory_cost_company_currency" invisible="True" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creo que esta manera de hacer el campo invisible no funciona. ¿No se debería quedar como antes?
<field name="reporting_level" position="attributes"> | ||
<attribute name="invisible" /> | ||
</field> | ||
<field name="reporting_level" invisible="False" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quizás esto se pueda quitar, ya que reporting_level no es un campo invisible.
7101629
to
e325148
Compare
@manuelregidor ya he realizado los cambios que indicas. Gracias! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical review. LGTM
@victoralmau Por tu parte cómo lo ves? |
Perfecto, uno menos. Gracias a todos por las contribuciones. /ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 3bf825b. Thanks a lot for contributing to OCA. ❤️ |
Se ha suprimido el "data/account_fiscal_position_template.xml" del manifest puesto que las posiciones fiscales se definen en el template es_common.