[17.0][MIG] l10n_es_account_statement_import_n43: migration to 17.0 #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bank_statement para importar extractos bancarios N43
…on monedas distintas de euros segun issue OCA#217 y basado en comentario de @fgarciag2001
…baciones extra para obtener el partner extraídas del n43 de Bankia Y Sabadell
…ing other statement formats
Improvements ------------ * Counterpart account automatically detected from N43 type (deactivated for now) * Tests
…een 'fecha_valor' and 'fecha_oper'.
…tros 22, nº documento incorrecto
* Metafiles updated * Test adapted to Python 3 * Test coverage improved
…te_type With this, this is compatible with tests that creates journals before this module is loaded.
* Standard procedure * Override method for adding the supported format * README by fragments * Tests adapted for new date format and order
…tween type of exception raised adn type of exception catched
Currently translated at 100.0% (14 of 14 strings) Translation: l10n-spain-12.0/l10n-spain-12.0-l10n_es_account_bank_statement_import_n43 Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-l10n_es_account_bank_statement_import_n43/gl/
…compatibility with BBVA files (OCA#1056) Some statement files include BOM data (https://es.wikipedia.org/wiki/Marca_de_orden_de_bytes) at the beginning of the file, making them non readable by current parser, as fixed positions are moved in these cases and thus expected data is not matched. As ASCII, which is the encoding used in files according specification, is a subset of UTF-8, there's no danger in using it with the variant 'utf-8-sig' for handling if BOM marker is present or not.
…her encodings + flake8
…n tests with other statement import modules Journal in context should be available since the beginning, as it can be used in default get for example.
…ment as the start date
Currently translated at 100.0% (15 of 15 strings) Translation: l10n-spain-13.0/l10n-spain-13.0-l10n_es_account_bank_statement_import_n43 Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-13-0/l10n-spain-13-0-l10n_es_account_bank_statement_import_n43/es/
…lient Other modules can add a partner called "Test partner", as the name is very generic, provoking an error in the test. We specify another name that don't collapse with other data for avoiding it.
…unt_bank_statement_import_n43 to v14
If we have very short concepts, there's a chance that the stripped text on the subsequent bank patterns matches with a partner, without the concept being really a partner. Example: "2301IMPUESTOS", taking "ESTOS" as name to match, which can match with "GESTOS S.L.". For avoiding this, we put a minimal string length of 8 chars for making the match. TT44038
…nce (same as v13) The reference was removed by mistake: - Migration to 14.0 OCA@51181af#diff-f258811a1845bb979e1b791f3ba00780796578f57ce356f088cd176425b1aff2R366 (ref is changed to payment_ref) - Remove name assignment (OCA@62f5186#diff-f258811a1845bb979e1b791f3ba00780796578f57ce356f088cd176425b1aff2R365) (payment_ref is now set with conceptos) - Populate payment_ref if not conceptos: OCA@4fb2933 TT45629
manuelregidor
force-pushed
the
17.0-mig-l10n_es_account_statement_import_n43
branch
from
6453205 to
82c69fb
Compare
Jesarregui
approved these changes
May 8, 2024
manuelregidor
force-pushed
the
17.0-mig-l10n_es_account_statement_import_n43
branch
from
82c69fb to
d7fdac9
Compare
|
@HaraldPanten @ValentinVinagre Ya está la dependencia migrada |
HaraldPanten
approved these changes
May 15, 2024
|
/ocabot migration l10n_es_account_statement_import_n43 |
|
This PR has the |
1 similar comment
|
This PR has the |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 15af2ae. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration
Depends on OCA/bank-statement-import#692