[17.0][MIG] l10n_es_facturae: Migration to 17.0 #3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiadavid
force-pushed
the
17.0-mig-l10n_es_facturae
branch
3 times, most recently
from
1dbe6d0
to
3f8a2c4
Compare
|
He modificado la creación del .xml para que en las facturas rectificativas no de error en los test, Si puedes echarle un ojo para ver que el formato sea correcto, yo creo que si, el cambio está en los importes que están en negativo. Si como lo he hecho está bien, en la v16 entonces también estaría mal, pero como no estaban funcionando los tests no nos hemos dado cuenta... |
|
@ramiadavid tras este commit 41f5fc5 creo que ya no es necesario el fix del 303 |
|
@etobella Mañana hago rebase y lo pruebo |
ramiadavid
force-pushed
the
17.0-mig-l10n_es_facturae
branch
from
3f8a2c4
to
fe2921f
Compare
|
@etobella Ya está, sin problemas |
|
@ramiadavid Te he hecho un PR en tu branch modificando la forma de importar los datos. Es mucho más limpio que una función harcodeando. Que opinas ramiadavid#1 |
|
/ocabot migration l10n_es_facturae |
|
@etobella Lo veo bien, el tema de las facturas rectificativas has podido mirarlo? |
ramiadavid
force-pushed
the
17.0-mig-l10n_es_facturae
branch
from
8880b17
to
c346cb4
Compare
|
A ver, los tests salen bien, por lo que para mi está bien |
|
@etobella pues entonces en la v16 está mal, porque si ejecutas los tests dan error... |
luisDIXMIT
reviewed
May 2, 2024
| denominado "Crear fichero Facturae" Podremos visualizar automáticamente | ||
| campos extra de facturación electrónica si el cliente es de facturación | ||
| electrónica. Estos campos se podrán editar a nivel de factura o de | ||
| línea. En el caso de línea, aparecera un botón con un pop-up con todo el |
There was a problem hiding this comment.
No consigo ver la funcionalidad en la que a nivel de línea se pueden editar datos de facturae. ¿Sigue activa la funcionalidad? ¿Cómo se reproduce?
|
@ramiadavid Puedes mirarte los comentarios de @luisDIXMIT ? |
|
Lo reviso este fin de semana |
ramiadavid
force-pushed
the
17.0-mig-l10n_es_facturae
branch
from
c346cb4
to
6290a51
Compare
|
/ocabot rebase |
|
@etobella The rebase process failed, because command |
|
@ramiadavid puedes hacer el rebase manual 🙏 Es para poder hacer una última review y mergear ya, que este PR se está enquistando sinó. |
|
Mañana lo reviso |
ramiadavid
force-pushed
the
17.0-mig-l10n_es_facturae
branch
from
6290a51
to
591246c
Compare
pedrobaeza
requested changes
Jun 14, 2024
|
/ocabot rebase |
… on non facturae customers
Mostrar los importes en negativo al generar el fichero facturae de facturas rectificativas
You can invoice to any contact, so there's no reason to hide Facturae fields for childrens that are not invoice addresses. TT45821
Se corrige el problema de generar el archivo xsig cuando alguno de los impuestos es con precio incluido que la administración lo rechaza
As it was, only accountant users can set Facturae check, as the field was inside a group with such restriction. It doesn't matter that the field itself has another less restricting group. Thus, we put the initial check in the same group as the rest, and move the visibility attributes to each field. TT47097
It was transferred to each field, but forgotten to be removed on the group. TT47203
…grahy library version We want to avoid the installation of newer versions that might be incompatible with odoo
ramiadavid
force-pushed
the
17.0-mig-l10n_es_facturae
branch
2 times, most recently
from
d83036b
to
05fed02
Compare
ramiadavid
force-pushed
the
17.0-mig-l10n_es_facturae
branch
from
05fed02
to
62b30b8
Compare
|
Buenos días compañeros! Gracias! |
pedrobaeza
approved these changes
Jul 11, 2024
|
On my way to merge this fine PR! |
|
This PR has the |
|
Congratulations, your PR was merged at edd0aa7. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.