[12.0][MIG] resource_multi_week_calendar #1389
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
…calendar This is the bones of the implementation. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
…atch This is the real implementation work. With this method implemented, all other methods correctly get the correct week each time. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
The epoch date is hidden on the child anyway. Let's just hide it, and always make sure to get the parent's epoch date. This gets rid of the complicated computation stuff that won't backport well to v12. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
…s attendances The idea here is that the children contain all the logic/attendances, and the parent is just a holder of children. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
|
@huguesdk Backport done. |
4 tasks
carmenbianca
force-pushed
the
12.0-mig-resource_multi_week_calendar
branch
from
05e4d5e
to
698f076
Compare
I need this elsewhere. It _technically_ reduces performance by doing the same calculation twice, but this module is horrible as pertains to performance in any case. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
carmenbianca
force-pushed
the
12.0-mig-resource_multi_week_calendar
branch
from
698f076
to
50f0b0c
Compare
carmenbianca
commented
Sep 4, 2024
carmenbianca
commented
Sep 4, 2024
- `parent_calendar_id` is now `ondelete="cascade"`. - Renamed `family_calendar_ids` to `multi_week_calendar_ids`. - Renamed `current_calendar_id` to `current_multi_week_calendar_id`. - Renamed `_get_calendar` to `_get_multi_week_calendar`. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
- Improved the comment on how week_sequence works. - Renamed family_size to calendar_count - Added a comment on _get_multi_week_calendar() returning a 1-item recordset. - Re-optimised the current week calculation. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
carmenbianca
force-pushed
the
12.0-mig-resource_multi_week_calendar
branch
from
6766eea
to
098a235
Compare
carmenbianca
commented
Sep 9, 2024
|
Review with @huguesdk finished, all things addressed. |
huguesdk
approved these changes
Sep 9, 2024
carmenbianca
force-pushed
the
12.0-mig-resource_multi_week_calendar
branch
from
098a235
to
c7a15cf
Compare
…ndar Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
carmenbianca
force-pushed
the
12.0-mig-resource_multi_week_calendar
branch
from
c7a15cf
to
1d4db07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A backport of #1384
Internal task: T12626