-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][FIX] hr_employee_firstname: removed useless mapped address_home_id #1369
base: 17.0
Are you sure you want to change the base?
Conversation
Hi @Savoir-faire Linux, @luisg123v, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as in #1370
Regarding commit message:
- Title doesn't conform guidelines
- Missing commit description
Besides, regarding PR description:
- Not clear enough, why the OCB should affect? This should work with mnative Odoo
- Link is not a permalink
4a6a5a6
to
529904e
Compare
Hi @luisg123v Regards |
If the partner_firstname module is installed, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @luisg123v , |
882a0b4
to
529904e
Compare
@@ -168,7 +168,6 @@ def _install_employee_firstname(self): | |||
def _update_partner_firstname(self): | |||
for employee in self: | |||
partners = employee.mapped("user_id.partner_id") | |||
partners |= employee.mapped("address_home_id") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be replaced by work_contact_id
? Or is it expected for it to be removed?
Hi @DorianMAG, I still see the old commit message. Could you check again, please? Regards, |
Hello, yes, thank you, I'll take a look at it quickly. |
529904e
to
d9a012f
Compare
@luisg123v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Commit message is not correct yet, it now seems the combination of two different commits.
- Please rebase to see if CI is fixed.
…ntact_id for v17 this no longer exists in v17 and replaced by a non-relational field (field.char) named private_street
d9a012f
to
5e7f5b8
Compare
Done |
Remove useless mapped.
The source code has changed in OCB/OdooSA.
The relational field no longer exists on the address in V17.
https://github.com/OCA/OCB/blob/3afef8250c829406a8fd227a6bd9f71c4f80ff29/addons/hr/models/hr_employee.py#L49