Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] hr_employee_ppe: fix error when assigning multiple PPE to an employee. #1351

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[FIX] hr_employee_ppe: fix error when assigning multiple PPE to an employee. #1351

merged 1 commit into from
Sep 23, 2024

Conversation

azucenatrey
Copy link

Fix
'''
Error while validating constraint
Expected singleton: hr.employee.ppe(5, 6)
'''
error when assigning multiple PPE to an employee.

@azucenatrey
[FIX] hr_employee_ppe: fix
e169197 
'''
     Error while validating constraint
     Expected singleton: hr.employee.ppe(5, 6)
'''
error when assigning multiple PPE to an employee.
@OCA-git-bot
Copy link
Contributor

Hi @eduaparicio, @marcelsavegnago,
some modules you are maintaining are being modified, check this out!

@azucenatrey azucenatrey mentioned this pull request May 16, 2024
Closed
@azucenatrey
Copy link
Author

Solution proposed for this issue: #1352

marcelsavegnago
marcelsavegnago approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cubells
cubells approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@cubells cubells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

It's Yes for me.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024
@azucenatrey
Copy link
Author

Hi @eduaparicio, @marcelsavegnago
Please can you review this pull request to fix an error to avoid that it is marked as "no stale"? Thanks.

@marcelsavegnago
Copy link
Member

ping @etobella @OCA/human-resources-maintainers

@etobella
Copy link
Member

/ocabot merge patch

Can you port the change to next versions?

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-1351-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d31ec2a into OCA:12.0 Sep 23, 2024
3 of 4 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a392345. Thanks a lot for contributing to OCA. ❤️

@azucenatrey
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@cubells cubells cubells approved these changes

@etobella etobella etobella approved these changes

@MiguelPoyatos MiguelPoyatos MiguelPoyatos approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@azucenatrey @OCA-git-bot @marcelsavegnago @etobella @cubells @MiguelPoyatos