[16.0][MIG] website_sale_product_attribute_value_filter_existing: Migration to 16.0 #773

anothingguy · 2023-03-20T08:49:05Z

No description provided.

… to v13

…nt_status

…ort, prettier

… to 14.0

…ort, prettier

… to 15.0 [UPD] Update website_sale_product_attribute_value_filter_existing.pot

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-15.0/e-commerce-15.0-website_sale_product_attribute_value_filter_existing Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_product_attribute_value_filter_existing/

…ort, prettier

chienandalu

Tested. Good work, thanks! :) Some minor comments:

chienandalu · 2023-03-23T11:31:19Z

...lter_existing/static/src/js/website_sale_product_attribute_value_filter_existing_tour.esm.js

+var domReady = new Promise(function (resolve) {
+    $(resolve);
+});
+var ready = Promise.all([domReady, session.is_bound]);


I bet this isn't needed :)

Suggested change

var domReady = new Promise(function (resolve) {

$(resolve);

});

var ready = Promise.all([domReady, session.is_bound]);

yep, at the beginning, I didn't add this ready, keep it same as v15. but without this ready, the running tests somehow is not stable, 50% passed and 50% failed. So I searched and tried to add this ready to make sure this tests run when DOM is ready

Yeah, when tours fail that randomly is quite annoying. Ok then 👍

yeah, I removed this redundant code and just keep step_delay to make sure there is enough time between steps

chienandalu · 2023-03-23T11:31:30Z

...lter_existing/static/src/js/website_sale_product_attribute_value_filter_existing_tour.esm.js

+    {
+        test: true,
+        url: "/shop",
+        wait_for: ready,


Suggested change

wait_for: ready,

chienandalu · 2023-03-23T11:33:46Z

...ute_value_filter_existing/tests/test_website_sale_product_attribute_value_filter_existing.py

-            url_path="/",
-            code="%s.run('%s')" % tour,
-            ready="%s.tours['%s'].ready" % tour,
+            step_delat=100,


Is it needed anyway?

Suggested change

step_delat=100,

step_delay=100,

yes, I will keep this to make sure there is enough time between steps. Some tests in Odoo modules are still using this

chienandalu · 2023-03-23T11:54:27Z

website_sale_product_attribute_value_filter_existing/readme/USAGE.rst

@@ -0,0 +1,3 @@
+* Go to Website Shop
+* Active product attributes filter


This has changed a bit in v16 as now is a theme panel option that is enabled on either top or bottom in the layout. I'd move it to CONFIGURATION.rst as well.

yes, moved to CONFIGURATION.rst and update more details. thanks for pointing out

…ration to 16.0

chienandalu

Thanks! 👍

OCA-git-bot · 2023-04-05T12:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2023-04-05T12:05:23Z

/ocabot merge nobump

OCA-git-bot · 2023-04-05T12:05:31Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-773-by-pedrobaeza-bump-nobump, awaiting test results.

pedrobaeza · 2023-04-05T12:05:32Z

/ocabot migration website_sale_product_attribute_value_filter_existing

Signed-off-by pedrobaeza

OCA-git-bot · 2023-04-05T12:13:21Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-773-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

gurneyalex · 2023-04-05T14:46:27Z

/ocabot merge nobump

OCA-git-bot · 2023-04-05T14:46:38Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-773-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot · 2023-04-05T14:54:05Z

Congratulations, your PR was merged at 1718312. Thanks a lot for contributing to OCA. ❤️

CarlosRoca13 and others added 13 commits March 15, 2023 16:19

[IMP] : black, isort, prettier

0c96e71

[MIG] website_sale_product_attribute_value_filter_existing: Migration…

2c6519f

… to v13

[FIX] website_sale_product_attribute_value_filter_existing: developme…

7340b4e

…nt_status

Added translation using Weblate (Spanish)

6496fcb

Added translation using Weblate (Catalan)

6b7f72b

Added translation using Weblate (Dutch)

97c06cf

[IMP] website_sale_product_attribute_value_filter_existing: black, is…

79310ed

…ort, prettier

[MIG] website_sale_product_attribute_value_filter_existing: Migration…

80d8ea8

… to 14.0

[IMP] website_sale_product_attribute_value_filter_existing: black, is…

ea67fc9

…ort, prettier

[MIG] website_sale_product_attribute_value_filter_existing: Migration…

23ef6c8

… to 15.0 [UPD] Update website_sale_product_attribute_value_filter_existing.pot

[UPD] README.rst

ec68b38

[IMP] website_sale_product_attribute_value_filter_existing: black, is…

7e658f5

…ort, prettier

anothingguy mentioned this pull request Mar 20, 2023

Migration to version 16.0 #683

Open

33 tasks

anothingguy marked this pull request as draft March 22, 2023 04:06

anothingguy force-pushed the 16.0-mig-website_sale_product_attribute_value_filter_existing branch from 9c2b71b to d424e0f Compare March 22, 2023 11:16

anothingguy changed the title ~~[16.0][MIG] website_sale_product_attribute_value_filter_existing~~ [16.0][MIG] website_sale_product_attribute_value_filter_existing: Migration to 16.0 Mar 22, 2023

anothingguy force-pushed the 16.0-mig-website_sale_product_attribute_value_filter_existing branch 2 times, most recently from 6957932 to d0966dd Compare March 23, 2023 04:16

anothingguy marked this pull request as ready for review March 23, 2023 04:21

chienandalu suggested changes Mar 23, 2023

View reviewed changes

[16.0][MIG] website_sale_product_attribute_value_filter_existing: Mig…

bba2f62

…ration to 16.0

anothingguy force-pushed the 16.0-mig-website_sale_product_attribute_value_filter_existing branch from d0966dd to bba2f62 Compare March 24, 2023 10:12

chienandalu approved these changes Mar 24, 2023

View reviewed changes

StephaneMangin approved these changes Apr 5, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 5, 2023

OCA-git-bot added the bot is merging ⏳ label Apr 5, 2023

OCA-git-bot added a commit that referenced this pull request Apr 5, 2023

Merge PR #773 into 16.0

0cb1e69

Signed-off-by pedrobaeza

OCA-git-bot added this to the 16.0 milestone Apr 5, 2023

OCA-git-bot removed the bot is merging ⏳ label Apr 5, 2023

OCA-git-bot added the bot is merging ⏳ label Apr 5, 2023

OCA-git-bot merged commit dcd2e60 into OCA:16.0 Apr 5, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] website_sale_product_attribute_value_filter_existing: Migration to 16.0 #773

[16.0][MIG] website_sale_product_attribute_value_filter_existing: Migration to 16.0 #773

anothingguy commented Mar 20, 2023

chienandalu left a comment

chienandalu Mar 23, 2023

anothingguy Mar 24, 2023

chienandalu Mar 24, 2023

anothingguy Mar 24, 2023

chienandalu Mar 23, 2023

chienandalu Mar 23, 2023

anothingguy Mar 24, 2023

chienandalu Mar 23, 2023

anothingguy Mar 24, 2023

chienandalu left a comment

OCA-git-bot commented Apr 5, 2023

pedrobaeza commented Apr 5, 2023

OCA-git-bot commented Apr 5, 2023

pedrobaeza commented Apr 5, 2023

OCA-git-bot commented Apr 5, 2023

gurneyalex commented Apr 5, 2023

OCA-git-bot commented Apr 5, 2023

OCA-git-bot commented Apr 5, 2023

		@@ -0,0 +1,3 @@
		* Go to Website Shop
		* Active product attributes filter

[16.0][MIG] website_sale_product_attribute_value_filter_existing: Migration to 16.0 #773

[16.0][MIG] website_sale_product_attribute_value_filter_existing: Migration to 16.0 #773

Conversation

anothingguy commented Mar 20, 2023

chienandalu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 5, 2023

pedrobaeza commented Apr 5, 2023

OCA-git-bot commented Apr 5, 2023

pedrobaeza commented Apr 5, 2023

OCA-git-bot commented Apr 5, 2023

gurneyalex commented Apr 5, 2023

OCA-git-bot commented Apr 5, 2023

OCA-git-bot commented Apr 5, 2023