Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] website_sale_product_detail_attribute_image: migration to 16.0 #759

Conversation

Segui-S73
Copy link

Standard migration from 15.0

@Segui-S73 Segui-S73 force-pushed the 16.0-mig-website_sale_product_detail_attribute_image branch 6 times, most recently from e8c9e11 to e3a9548 Compare February 22, 2023 16:04
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 25, 2023
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tiny comment

@@ -22,7 +27,7 @@ odoo.define("website_sale_product_detail_attribute_image.tour", function (requir
{
url: "/shop",
test: true,
wait_for: base.ready(),
wait_for: ready,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed at all?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not necessary, in 15.0 it was configured with the wait_for parameter and I migrated it as a precaution, I am going to delete it.
Sorry for the delay.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@pedrobaeza
Copy link
Member

@Segui-S73 can you answer the comment? And one thing, isn't this something included already in core?

sergio-teruel and others added 20 commits July 7, 2023 12:35
…CA#288)

* [11.0][NEW] website_sale_product_detail_attribute_image: new module

* [11.0][IMP] website_sale_product_detail_attribute_image: Remove boolean_widget from tree view
Bebsite name -> Website name
Odoo 13 doens't use less anymore. Change it to scss.
Currently translated at 44.4% (4 of 9 strings)

Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_detail_attribute_image
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_detail_attribute_image/nl/
Currently translated at 100.0% (9 of 9 strings)

Translation: e-commerce-14.0/e-commerce-14.0-website_sale_product_detail_attribute_image
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_product_detail_attribute_image/nl/
Currently translated at 91.6% (11 of 12 strings)

Translation: e-commerce-14.0/e-commerce-14.0-website_sale_product_detail_attribute_image
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_product_detail_attribute_image/pt/
Currently translated at 100.0% (12 of 12 strings)

Translation: e-commerce-14.0/e-commerce-14.0-website_sale_product_detail_attribute_image
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_product_detail_attribute_image/es_AR/
Currently translated at 100.0% (11 of 11 strings)

Translation: e-commerce-14.0/e-commerce-14.0-website_sale_product_detail_attribute_image
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_product_detail_attribute_image/pt/
@Segui-S73 Segui-S73 force-pushed the 16.0-mig-website_sale_product_detail_attribute_image branch from e3a9548 to 767e470 Compare July 7, 2023 10:37
@Segui-S73 Segui-S73 force-pushed the 16.0-mig-website_sale_product_detail_attribute_image branch from 767e470 to 83374a9 Compare July 7, 2023 10:40
@pedrobaeza
Copy link
Member

/ocabot migration website_sale_product_detail_attribute_image
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 7, 2023
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-759-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jun 7, 2023
33 tasks
@OCA-git-bot OCA-git-bot merged commit e3ebdc0 into OCA:16.0 Jul 7, 2023
4 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 349687f. Thanks a lot for contributing to OCA. ❤️

@ioans73 ioans73 deleted the 16.0-mig-website_sale_product_detail_attribute_image branch July 11, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.