-
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] website_sale_product_detail_attribute_image: migration to 16.0 #759
[16.0][MIG] website_sale_product_detail_attribute_image: migration to 16.0 #759
Conversation
e8c9e11
to
e3a9548
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tiny comment
@@ -22,7 +27,7 @@ odoo.define("website_sale_product_detail_attribute_image.tour", function (requir | |||
{ | |||
url: "/shop", | |||
test: true, | |||
wait_for: base.ready(), | |||
wait_for: ready, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it needed at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not necessary, in 15.0 it was configured with the wait_for
parameter and I migrated it as a precaution, I am going to delete it.
Sorry for the delay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@Segui-S73 can you answer the comment? And one thing, isn't this something included already in core? |
…CA#288) * [11.0][NEW] website_sale_product_detail_attribute_image: new module * [11.0][IMP] website_sale_product_detail_attribute_image: Remove boolean_widget from tree view
Bebsite name -> Website name
Odoo 13 doens't use less anymore. Change it to scss.
Currently translated at 44.4% (4 of 9 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_detail_attribute_image Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_detail_attribute_image/nl/
Currently translated at 100.0% (9 of 9 strings) Translation: e-commerce-14.0/e-commerce-14.0-website_sale_product_detail_attribute_image Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_product_detail_attribute_image/nl/
Currently translated at 91.6% (11 of 12 strings) Translation: e-commerce-14.0/e-commerce-14.0-website_sale_product_detail_attribute_image Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_product_detail_attribute_image/pt/
Currently translated at 100.0% (12 of 12 strings) Translation: e-commerce-14.0/e-commerce-14.0-website_sale_product_detail_attribute_image Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_product_detail_attribute_image/es_AR/
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-14.0/e-commerce-14.0-website_sale_product_detail_attribute_image Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_product_detail_attribute_image/pt/
e3a9548
to
767e470
Compare
767e470
to
83374a9
Compare
/ocabot migration website_sale_product_detail_attribute_image |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 349687f. Thanks a lot for contributing to OCA. ❤️ |
Standard migration from 15.0