-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] delivery_package_number: Migration to 17.0 #839
base: 17.0
Are you sure you want to change the base?
Conversation
[UPD] Update delivery_package_number.pot [UPD] README.rst
[UPD] Update delivery_package_number.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_package_number Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_package_number/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-15.0/delivery-carrier-15.0-delivery_package_number Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-15-0/delivery-carrier-15-0-delivery_package_number/
…ransfer wizard if picking have not carrier. TT38549
…delivery_carrier_label module
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_package_number Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_package_number/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_package_number Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_package_number/
19631e3
to
9f90731
Compare
9f90731
to
e4e66f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code + functional
@@ -10,14 +10,13 @@ | |||
"license": "AGPL-3", | |||
"installable": True, | |||
"application": False, | |||
"depends": ["delivery"], | |||
"depends": ["delivery", "stock_delivery"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this new dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a new glue module for pickings + delivery, the base delivery
only handles the carrier models and adds shipping methods to sales now. Though the depends could be abbreviated to just ["stock_delivery"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I see. Maybe we should rename this to stock_delivery_package_number
? cc @chienandalu @sergio-teruel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odoo hasn't renamed any of their modules to stock_delivery_x
so far, not even another glue module delivery_stock_picking_batch
. I think it would more consistent to keep the current delivery_x
naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep it in the short form as well....
/ocabot migration delivery_package_number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are pending forward ports in v16 as well: #788
ping @sergio-teruel
Standard migration to 17.0