Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] delivery_package_number: Migration to 17.0 #839

Open
wants to merge 26 commits into
base: 17.0
Choose a base branch
from

Conversation

Josep-s73
Copy link

Standard migration to 17.0

chienandalu and others added 25 commits June 24, 2024 13:31
[UPD] Update delivery_package_number.pot

[UPD] README.rst
[UPD] Update delivery_package_number.pot

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_package_number
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_package_number/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-15.0/delivery-carrier-15.0-delivery_package_number
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-15-0/delivery-carrier-15-0-delivery_package_number/
…ransfer wizard if picking have not carrier.

TT38549
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_package_number
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_package_number/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_package_number
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_package_number/
@Josep-s73 Josep-s73 force-pushed the 17.0-mig-delivery_package_number branch from 19631e3 to 9f90731 Compare June 24, 2024 15:41
Copy link
Member

@hildickethan hildickethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code + functional

@@ -10,14 +10,13 @@
"license": "AGPL-3",
"installable": True,
"application": False,
"depends": ["delivery"],
"depends": ["delivery", "stock_delivery"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this new dependency?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a new glue module for pickings + delivery, the base delivery only handles the carrier models and adds shipping methods to sales now. Though the depends could be abbreviated to just ["stock_delivery"]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see. Maybe we should rename this to stock_delivery_package_number? cc @chienandalu @sergio-teruel

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odoo hasn't renamed any of their modules to stock_delivery_x so far, not even another glue module delivery_stock_picking_batch. I think it would more consistent to keep the current delivery_x naming

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep it in the short form as well....

@pedrobaeza
Copy link
Member

/ocabot migration delivery_package_number

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 8, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 8, 2024
23 tasks
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are pending forward ports in v16 as well: #788

ping @sergio-teruel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet