Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][PORT] account_invoice_start_end_dates: add start/end dates in tree view of move lines #303

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

henrybackman
Copy link

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

<field name="must_have_dates" invisible="1" />
<field
name="start_date"
attrs="{'required': [('must_have_dates', '=', True)]}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
attrs="{'required': [('must_have_dates', '=', True)]}"
required="must_have_dates"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

/>
<field
name="end_date"
attrs="{'required': [('must_have_dates', '=', True)]}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
attrs="{'required': [('must_have_dates', '=', True)]}"
required="must_have_dates"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

…move lines

The 2 new fields are hidden by default
@henrybackman henrybackman force-pushed the oca-port-from-14.0-to-17.0-pr-195 branch from 60a27ab to 5879beb Compare September 12, 2024 09:12
@sebalix
Copy link
Contributor

sebalix commented Sep 12, 2024

In fact the change was already there but done through another commit. The only relevant change brought here is the split of XML views in two files: account_move.xml and account_move_line.xml, reducing the gap of commits between 14.0 and 17.0.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants