-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ro_import.owl #258
Update ro_import.owl #258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebastianduesing there seem to have been some pretty serious changes in RO that create cyclic dependencies. I will have to deal with that but changing the COB pipeline a bit. So - no need for you to do anything now, just wait.
src/ontology/imports/ro_import.owl
Outdated
|
||
# Class: <http://purl.obolibrary.org/obo/COB_0000121> (measurement datum) | ||
|
||
AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/COB_0000121> "measurement datum") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmungall now the fun starts.. :D Cyclic dependencies.
For now I will hack the make goal to deal with this, but I guess we need to switch COB to base merging in order to avoid this stuff.
src/ontology/imports/ro_import.owl
Outdated
|
||
AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/COB_0001000> "A process during which an organism comes into contact with another entity.") | ||
AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/COB_0001000> "exposure of organism"@en) | ||
SubClassOf(<http://purl.obolibrary.org/obo/COB_0001000> <http://purl.obolibrary.org/obo/BFO_0000015>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove.
@matentzn Got it, thanks! Just let me know if/when you need me to do anything. |
Redundant with #259 |
While attempting to import an object property that OBI uses, James and I noticed that the diff on ro_import.owl was quite large, and it looks like the file hasn't been updated in a while. This PR updates ro_import.owl without the new object property import. If everything looks okay, I'll make a PR for the new import once this one gets merged.