Update ro_import.owl #258
Closed
Update ro_import.owl #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matentzn
requested changes
Mar 27, 2024
There was a problem hiding this comment.
@sebastianduesing there seem to have been some pretty serious changes in RO that create cyclic dependencies. I will have to deal with that but changing the COB pipeline a bit. So - no need for you to do anything now, just wait.
src/ontology/imports/ro_import.owl
Outdated
|
|
||
| # Class: <http://purl.obolibrary.org/obo/COB_0000121> (measurement datum) | ||
|
|
||
| AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/COB_0000121> "measurement datum") |
There was a problem hiding this comment.
@cmungall now the fun starts.. :D Cyclic dependencies.
For now I will hack the make goal to deal with this, but I guess we need to switch COB to base merging in order to avoid this stuff.
src/ontology/imports/ro_import.owl
Outdated
|
|
||
| AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/COB_0001000> "A process during which an organism comes into contact with another entity.") | ||
| AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/COB_0001000> "exposure of organism"@en) | ||
| SubClassOf(<http://purl.obolibrary.org/obo/COB_0001000> <http://purl.obolibrary.org/obo/BFO_0000015>) |
|
@matentzn Got it, thanks! Just let me know if/when you need me to do anything. |
|
Redundant with #259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to import an object property that OBI uses, James and I noticed that the diff on ro_import.owl was quite large, and it looks like the file hasn't been updated in a while. This PR updates ro_import.owl without the new object property import. If everything looks okay, I'll make a PR for the new import once this one gets merged.