Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: schemas live in src folder #4361

Merged
merged 15 commits into from
Feb 20, 2025
Merged

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Feb 13, 2025

Part of #4356

  • remove schemas folder - the work-in-progress schemas are in the src/schemas/validation folder
  • only test the work-in-progress schema sources
  • only measure test coverage for work-in-progress schema sources
  • create deployable schema files from schema sources in the src/schemas/validation
  • template workflow for schema publishing from vX.Y-dev branches

Tick one of the following options:

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

@ralfhandl ralfhandl requested review from a team as code owners February 13, 2025 22:52
@ralfhandl ralfhandl changed the base branch from main to dev February 13, 2025 22:57
on:
push:
branches:
- main
- vX.Y-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a list of the actual dev branch names here

@@ -39,14 +39,14 @@ Schemas to perform additional optional validation are [under consideration](http

Improvements can be submitted by opening a PR against the `main` branch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the main branch! A dev branch, I think we mean.

@lornajane lornajane merged commit 92e5fc9 into OAI:dev Feb 20, 2025
2 checks passed
@ralfhandl ralfhandl deleted the dev-schemas-live-in-src branch February 20, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up /schemas on main branch Create dev build infrastructure
3 participants