-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: schemas live in src folder #4361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
5 tasks
This was
linked to
issues
Feb 14, 2025
duncanbeevers
approved these changes
Feb 15, 2025
5 tasks
ralfhandl
commented
Feb 18, 2025
lornajane
reviewed
Feb 20, 2025
on: | ||
push: | ||
branches: | ||
- main | ||
- vX.Y-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have a list of the actual dev branch names here
lornajane
reviewed
Feb 20, 2025
src/schemas/validation/README.md
Outdated
@@ -39,14 +39,14 @@ Schemas to perform additional optional validation are [under consideration](http | |||
|
|||
Improvements can be submitted by opening a PR against the `main` branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the main branch! A dev branch, I think we mean.
lornajane
reviewed
Feb 20, 2025
lornajane
approved these changes
Feb 20, 2025
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4356
schemas
folder - the work-in-progress schemas are in thesrc/schemas/validation
foldersrc/schemas/validation
vX.Y-dev
branchesTick one of the following options: