Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: test schemas in ./src and ./schemas #4333

Closed
wants to merge 5 commits into from

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Feb 6, 2025

Part of

Changes:

  • separate test fixtures for published schemas in ./schemas and next schema in ./src
  • one test script for all schema versions
  • schema test coverage also for next schema in ./src

Tick one of the following options:

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

@ralfhandl ralfhandl requested review from a team as code owners February 6, 2025 11:53
@ralfhandl ralfhandl linked an issue Feb 6, 2025 that may be closed by this pull request
5 tasks
@baywet
Copy link
Contributor

baywet commented Feb 6, 2025

from the meeting: we might want to name the directory 3.2 instead of vNext to match branching.
@handrews to have a look when brain is online :)

@handrews
Copy link
Member

handrews commented Feb 6, 2025

@ralfhandl I think I might just suggest calling "vNext" "dev" to match the branch. It's not clear to me that what's on the dev branch will always match the next version under development. In fact I feel like it's most likely to just be the same as whatever branch was most recently released as that's when cnanges are merged down to dev.

@ralfhandl
Copy link
Contributor Author

ralfhandl commented Feb 7, 2025

I think I might just suggest calling "vNext" "dev"

@handrews "dev" for "under development", or "src" for "stuff in the src folder"?

@ralfhandl ralfhandl requested a review from handrews February 7, 2025 10:15
@ralfhandl ralfhandl marked this pull request as draft February 13, 2025 20:53
@ralfhandl ralfhandl closed this Feb 13, 2025
@ralfhandl ralfhandl deleted the dev-test-schemas-in-src branch February 13, 2025 22:53
@ralfhandl ralfhandl removed a link to an issue Feb 14, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants