Dead letter queue support #96
Conversation
elindanielsson
commented
Jan 11, 2022
elindanielsson
commented
- Added support for a dead letter queue error filter
- Added support for prefixed temporary queues
|
Oh wow, that came unexpected 🤔 |
Haha, yeah, it's functionality that exists in Nybus V0, that we realized was missing in V1, but would be nice to have |
|
Next time better open an issue first so that I can be involved from the beginning :) |
Yes, will do |
| @@ -128,6 +128,11 @@ public Task NotifyFailAsync(Message message) | |||
|
|
|||
| public bool IsTypeAccepted(Type type) => _acceptedTypes.Contains(type); | |||
|
|
|||
| public Task SendMessageToErrorQueueAsync(Message message) | |||
| { | |||
| return Task.CompletedTask; | |||
There was a problem hiding this comment.
Can you try sketch an implementation for this as well?
There was a problem hiding this comment.
Do you have any suggestion on how best to do that? Do we create a another ISubject<Envelope> for the error messages? Or do you have a better idea?
There was a problem hiding this comment.
Ok, let's take a step back. how users are expected to interact with the DLQ?
There was a problem hiding this comment.
I would guess in most cases, that would be handled by a different application then, and from the perspective of that application, it would be considered a "normal" queue.
There was a problem hiding this comment.
uhm... seems correct. Let me sit a bit on this one and see if there is a clean way to implement local DLQ for the in-memory provider.
Fix for DLQ error filter test
Yes @Kralizek , it's ready from my pov |
