Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add material themes Deep Ocean and Lighter #270

Closed
wants to merge 16 commits into from

Conversation

David-Aguilo
Copy link

@David-Aguilo David-Aguilo commented Jan 3, 2024

Pull Request to add to NvChad the Material themes:

  • Deep Ocean
  • Lighter

Compared against the Material themes in JetBrains Products for C and Rust code using Clion and Rust-Rover respectively. Also used the material color palette: https://material-theme.com/docs/reference/color-palette/ and marco-cerovac's material nvim plugin: https://github.com/marko-cerovac/material.nvim as references.

Images comparing dmenu source code between nvim and clion:

  • Deep Ocean

imatge

  • Lighter

imatge

They aren't fully equal because things that appear the same under :Inspect have different colours in JetBrains. So I had to choose.

@siduck
Copy link
Member

siduck commented Mar 10, 2024

material-deep looks like pastel-dark.. I'll just add the light one

@siduck siduck changed the base branch from v2.0 to v2.5 March 10, 2024 07:43
siduck added a commit that referenced this pull request Mar 10, 2024
@siduck
Copy link
Member

siduck commented Mar 10, 2024

@David-Aguilo thanks for your PR, i wanted to port this theme by today soi commited from my side. Tons of changes were done!

@siduck siduck closed this Mar 10, 2024
@David-Aguilo
Copy link
Author

material-deep looks like pastel-dark.. I'll just add the light one

Hello. Thanks for the kind words. I have installed release 2.5 and checked pastelDark and feel it looks quite different to material-deep ocean:
imatge

Having pastelDark less contrast. I will continue to personally use material-deep ocean, though it is understandable if you feel it is unneeded.

@siduck
Copy link
Member

siduck commented Mar 11, 2024

@David-Aguilo in v3.0 we could add it then :) . Until then you use it as your local theme, and make sure the polish_hl has integration names -> hlgroups

for example u should wrap those hlgroups in treesitter table*

example : https://github.com/NvChad/base46/blob/v2.5/lua/base46/themes/solarized_osaka.lua#L59

@David-Aguilo
Copy link
Author

Yes, was wondering why it was looking weird. Thank you for the explanation.

@David-Aguilo
Copy link
Author

@s4nj1th Glad you like it. It's been my daily driver since I made it. Hopefully it can be added to the repo eventually. Though I don't know if I should make a new Merge Request for it, given that this one is closed. Should I make a new one @siduck ?

@siduck
Copy link
Member

siduck commented Sep 19, 2024

sure @David-Aguilo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants