fix(desktop): translate Mission Inbox section labels to English - #98
Merged
Conversation
PR #96 shipped the Mission Inbox with Vietnamese section labels (Cần bạn / Xong / Đang bay) left over from the design prototype, while every other string in the product is English — the empty states right under those headers already say "Nothing needs you" and "Nothing ready to review". Rename to Needs you / Ready to review / In flight and update the e2e assertions. Verified: biome + tsc clean, mission-inbox.spec.ts smoke 1/1. Signed-off-by: oscarlehuu <oscar.lehuu@gmail.com>
Two pre-existing lint/style/useImportType errors on main (merged while main CI runs were cancelled) fail Desktop Fast on any new branch: MessageComposer.tsx and useMentionSendFlow.ts. Auto-fixed with biome, plus formatting of the widened label object literal. Signed-off-by: oscarlehuu <oscar.lehuu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #96 shipped the Mission Inbox with Vietnamese section labels (Cần bạn / Xong / Đang bay) left over from the design prototype, while the rest of the product is English — the empty states directly under those headers already read "Nothing needs you — safe to close" / "Nothing ready to review".
Repo-wide sweep for Vietnamese diacritics in UI code found no other user-facing strings (remaining hits are test fixtures exercising Unicode paths, by design).
Verification
tsc --noEmitcleanmission-inbox.spec.tssmoke: 1/1 passed (assertions updated)