fix(desktop): rename 30617 create-menu action Project → Repository - #88
Merged
Conversation
Crew's create menu labeled the local-folder add action 'Project', but that flow publishes kind 30617 — a repository in upstream vocabulary. Upstream reserves 'Project' for kind 30621 (multi-repo grouping), which Crew has no surface for yet (folder-first D-014 remains the add path). User-visible copy renamed across the whole 30617 add chain: create-menu item, add dialog (title/label/submit), flow toasts, lib validation and duplicate-name errors, runtime timeout/failure messages, folder-picker title, and the create-menu aria-label no longer says 'project'. Internal identifiers, the Projects screen/nav, routes, and the #65 skipped 30621 upstream dialog tests are deliberately untouched. Contract tests now pin the full chain: any user-visible string calling the 30617 entity a Project in dialog/lib/runtime/picker fails the suite, so the vocabulary cannot regress one string at a time. Fixes #66 Signed-off-by: oscarlehuu <oscar.lehuu@gmail.com>
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add this Repository?/Repository name/Add Repository), flow toasts, lib validation + duplicate-name errors, runtime timeout/failure messages, folder-picker title (Select Repository workspace), and the menuaria-label(AT no longer hears "project" for the 30617 action).CreateProjectDialogtests (they keep clicking menuitem "Project" — correct once a real 30621 surface exists).project-commit-detail.spec.tsnow expects menuitem Repository.Tests
Verify
pnpm run checkgreen (biome + guards, all packages).project-add-local-workspace-ui-contract+relay-contract).pnpm run testhas pre-existing unrelated failures on main (React.actin TerminalSubstrate) — verified identical on origin/main, not introduced here.Built by gpt-5.6-luna xhigh (Hermes); reviewed by grok-4.5 (Hermes) — REQUEST_CHANGES: both required findings (remaining add-path strings incl. picker title + aria-label; contract coverage for dialog/lib/runtime/relay) addressed in this PR. Finding 3 (skipped-test split) confirmed as-is.
Fixes #66