upstream(sync): Tier 2 messaging — inbox delete, compact links, MCP todo scope - #319
Merged
Merged
Conversation
… prompts Pin the #289 conflict: a crew-evidence message that also contains a buzz:// permalink must stay an evidence card. Compact permalink chips, pickup follow-through, and MCP todo scope assertions fail until the upstream ports land. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: oscarlehuu <oscarlehuu@users.noreply.github.com>
Absorb Buzz block#5779, block#5638, block#6252, block#6186, and block#6216. MessageRowDefaultBody dispatch order is crew-evidence → handover → compact Buzz permalink chips → ordinary Markdown, so an evidence card with a buzz:// link still renders Accept/Reject instead of a chip. block#6186 pickup follow-through composes with Crew no-bare-ack (#283/#276). Wiki buzz://file citations stay inline (not chips). Inbox delete does not change Mission Inbox sections. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: oscarlehuu <oscarlehuu@users.noreply.github.com>
…dant The Playwright `has` locator must be relative to each message-row. Nested timeline-scoped locators never matched even when the evidence card rendered. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: oscarlehuu <oscarlehuu@users.noreply.github.com>
…atchet Move channel/message/entity chip renderers out of markdown.tsx so the already-over-limit file stays at or below the 1915-line base. Dispatch order is unchanged: crew-evidence → handover → compact links → Markdown. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: oscarlehuu <oscarlehuu@users.noreply.github.com>
|
UI proof on Walkthrough recording (evidence card with a tier2-messaging-evidence-inbox.mp4 Evidence card owns a crew-evidence + buzz:// rowAccept/Reject stay on the card. The permalink is an “Open PR in Crew” action, not a broken chip. Compact permalink chips + link metadataOrdinary Hover shows the pull-request metadata tooltip. Inbox deleteHome Inbox offers Delete; confirm dialog is “Delete message?”. Mission Inbox sections still intactNeeds attention / Ready to review / In flight remain on Home. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Absorb Buzz Tier 2 messaging into Crew: inbox delete, compact
buzz://permalink chips + metadata tooltips, pickup follow-through in the ACP prompt, and MCP todo scoped to the session.Fixes #289.
Upstream PRs (block/buzz): block#5779 inbox delete; block#5638 compact Buzz permalink chips; block#6252 compact Buzz link metadata; block#6186 prompt pickup follow-through; block#6216 MCP scope todo usage to session.
Conflict resolution
MessageRowDefaultBodydispatch order is crew-evidence → handover → compact links → Markdown. Evidence cards with abuzz://permalink still render Accept/Reject; they are not replaced by a chip. Compact chips live inside Markdown after those branches.buzz-dev-mcptodo tool description takes upstream session-checklist wording.Crew
buzz://filewiki citations stay inline links, not chips (unresolved vs the new compact metadata renderer — investigated, not expanded).Channel-first IA (#278): this change does not restore a Projects rail or Workbench. Compact chips navigate through existing project/channel routes.
Testing
desktop/src/shared/ui/markdown.test.mjs— bare permalink chips, wikibuzz://filestays inline.cargo test -p buzz-acp --lib shared_base_prompt_keeps_crew_office_sections— no-bare-ack + pickup follow-through + Crew office sections.cargo test -p buzz-dev-mcp --lib tool_description_scopes_todo.pnpm exec tsc --noEmitindesktop/.pnpm --filter buzz check:channel-first-ia.evidence-reactions.spec.ts(5 passed, including evidence+permalink vs ordinary chips),evidence-cross-check.spec.ts,inbox-edit.spec.ts(Inbox delete),mission-inbox.spec.ts.