perf(desktop): bound observer event retention - #307
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Runtime verification — desktop E2E mock bridge (
|
Summary
Related issueFixes #293 No duplicate issue or PR found. TestingTDD evidence:
Local gates, run on implementation commit
Full-window desktop smoke evidence: DONE - what is implemented, tests added, gates run + results, evidence files/links
IN PROGRESS - what is half-done, which files, what state it is in
TODO / NEXT - remaining steps for whoever picks this up, known risks, conflicts expected
|
7934af2 to
638bd65
Compare
Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-Authored-By: Oscar Le <oscar.lehuu@gmail.com> Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: oscarlehuu <oscarlehuu@users.noreply.github.com>
638bd65 to
a637afa
Compare
Summary
(agent, channel)key and 12 least-recently-read channel keys while preserving causal order, identity deduplication, and the existing single-event append contract.Related issue
Fixes #293
No duplicate issue or PR found.
Testing
TDD evidence:
sort_calls=1000.sort_calls=1.Local gates, run on implementation commit
d0a018e9d:pnpm --filter buzz check— passed (existing Biome diagnostics remain warnings/info).pnpm --filter buzz typecheck— passed.pnpm --filter buzz test— passed: 5,535 passed, 1 skipped.just test-unit— four out-of-scope failures reproduced unchanged on untouched PR base9bffb8cab5152aa110acfd69cee96c8bd7b74a0a:tests::command_inventory_is_stable,tests::subcommand_counts_are_stable,tests::subcommand_names_are_stable, andmigration::tests::embedded_migrator_contains_consolidated_initial_schema. This PR does not change Rust or CI configuration.Full-window desktop smoke evidence:
DONE - what is implemented, tests added, gates run + results, evidence files/links
git diff --merge-base origin/main HEAD.page_size=1000 sort_calls=1000before andpage_size=1000 sort_calls=1after.7934af2a9aff81a293f091c787ca15001deff414, including the user-pushed merge of currentmain; working tree is clean.NuncioCrew Gatepassed on the pre-merge implementation head. Per the stop order, gates were not rerun after the user-pushedmainmerge./home/ubuntu/issue-293-evidence/red-observer-retention.log/home/ubuntu/issue-293-evidence/green-observer-retention.log/home/ubuntu/issue-293-evidence/green-observer-regressions.log/home/ubuntu/issue-293-evidence/archive-ingest-before-after.txt/home/ubuntu/issue-293-evidence/gate-pnpm-buzz-check.log/home/ubuntu/issue-293-evidence/gate-pnpm-buzz-typecheck.log/home/ubuntu/issue-293-evidence/gate-pnpm-buzz-test.log/home/ubuntu/issue-293-evidence/gate-just-test-unit.log,/home/ubuntu/issue-293-evidence/gate-just-test-unit-main-verification.log/home/ubuntu/issue-293-evidence/issue-293-full-window.png/home/ubuntu/screencasts/pr307-observer-retention/pr307-observer-retention-edited.mp4/home/ubuntu/evidence/observer-retention/pr307-observer-retention.webp/home/ubuntu/evidence/observer-retention/03-live-second.png,/home/ubuntu/evidence/observer-retention/11-bravo-isolated.png,/home/ubuntu/evidence/observer-retention/12-alpha-remount.png/home/ubuntu/evidence/observer-retention-test-plan.mdIN PROGRESS - what is half-done, which files, what state it is in
TODO / NEXT - remaining steps for whoever picks this up, known risks, conflicts expected
mainmerge, rerun the documented desktop gates; do not alter.github/.mainmerged cleanly into the feature branch; no known code conflicts remain.Link to Devin session: https://app.devin.ai/sessions/fafa62bf95ed46489ace1c78029a6836
Requested by: @oscarlehuu