fix(desktop): surface why Add agent fails on create - #258
Merged
Conversation
Catalog create was clearing feedback onto the library surface, so submit errors never toasted inside the open Add agent modal. Hermes/defaults create also hid the harness picker, so an unavailable runtime disabled Add agent with no visible warning. Route create feedback to the catalog surface when that dialog is open, show a standalone unavailable-runtime banner outside Customize mode, and pass persona submit errors into the definition dialog. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: oscarlehuu <oscarlehuu@users.noreply.github.com>
AgentDefinitionDialog grew past the over-limit ratchet while adding the unavailable-runtime banner. Move name/instructions/warning UI into AgentDefinitionIdentityFields so Desktop Fast can pass again. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: oscarlehuu <oscarlehuu@users.noreply.github.com>
oscarlehuu
marked this pull request as ready for review
August 21, 2026 00:29
Co-authored-by: oscarlehuu <oscarlehuu@users.noreply.github.com>
Embedded Add agent Cancel wiped the form before the discard prompt, and name/instructions edits never marked the catalog shell dirty. Propagate hasUserChanges via onDirtyChange and defer embedded field reset until the parent actually closes. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: oscarlehuu <oscarlehuu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes silent / unexplained failures when adding a custom agent from the Add agent catalog modal — including Hermes and other runtimes.
Root causes found while investigating “Add agent does nothing for any runtime”:
librarytoast surface while the catalog modal was open, so failures (e.g. harness not installed) never appeared in the dialog.Add agentwith no visible warning.personaErrorMessage, notdefinitionError, so the red error line inside the form stayed empty.Also extracts identity fields into
AgentDefinitionIdentityFieldssoAgentDefinitionDialogstays under the desktop file-size ratchet.Related issue
None found matching this exact Add-agent / any-runtime failure (closest Hermes work is #51 / profile-binding UX).
Testing
node --test desktop/src/features/agents/ui/personaSubmitFeedback.test.mjs(6 passing)node desktop/scripts/check-file-sizes.mjs(AgentDefinitionDialog ~982 lines)biome checkon touched desktop agent UI filesManual checklist for reviewers:
persona-runtime-unavailablebanner and disabled Add.