fix(e2e): valid workflow trigger in bridge-relay-mutations (#177) - #185
Merged
Conversation
The workflow create/update fixture used trigger.on: manual, which TriggerDef rejects. Switch to webhook + a delay step so relay YAML validation accepts the definition while still asserting 30620/46020/5. Fixes #177 Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: oscarlehuu <oscarlehuu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Advisory Desktop E2E Integration rejected the workflow mutation fixture from #176/#172 because YAML used
trigger.on: manual, whichTriggerDefdoes not accept (message_posted|reaction_added|diff_posted|schedule|webhook).This updates create/update YAML in
bridge-relay-mutations.spec.tstoon: webhookwith a validdelaystep so relay validation accepts the definition. Kind/tag assertions for 30620 / 46020 / 5 are unchanged.Related issue
Fixes #177
Testing
Bridge/test-only — not UI-provable. Fix is scoped to the fixture YAML; Gate should stay green. Other noisy integration failures (
agents.spec.ts,profile.spec.ts) are out of scope.