Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NetBSD support #568

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Add NetBSD support #568

merged 3 commits into from
Sep 20, 2024

Conversation

0323pin
Copy link
Contributor

@0323pin 0323pin commented Sep 20, 2024

Hi,

I've packaged pueue for NetBSD and the package has been merged into pkgsrc main branch.
Commit log for reference, https://mail-index.netbsd.org/pkgsrc-changes/2024/09/19/msg307405.html

Now, in order to do this, I needed to add support to the relevant files, this PR.

The software is tested and works as expected.
For the package, we are currently using my fork as upstream. Hence, I cannot squash the commits since that would generate a new checksum and break the builds on our servers. Hopefully, you can do the commit squash when merging.

Once merged, I will regenerate all checksums and shift upstream to the proper one, i.e. your master.

Thanks!

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.28%. Comparing base (1c5f4aa) to head (7c5ca49).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   78.21%   78.28%   +0.06%     
==========================================
  Files          75       75              
  Lines        5844     5835       -9     
==========================================
- Hits         4571     4568       -3     
+ Misses       1273     1267       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

  3 files  ±0   19 suites  ±0   3m 4s ⏱️ -1s
161 tests ±0  161 ✅ ±0  0 💤 ±0  0 ❌ ±0 
340 runs  ±0  340 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7c5ca49. ± Comparison against base commit 1c5f4aa.

@Nukesor
Copy link
Owner

Nukesor commented Sep 20, 2024

Looks good to me :)
Don't worry about the commits, as long as they're sensible, there's no need to squash.

Lints have been addressed on the main branch. Not sure why they pop up though, I don't get them on my local machines, they only show up in CI o.O

@Nukesor Nukesor merged commit 98ae0d2 into Nukesor:main Sep 20, 2024
13 of 19 checks passed
@0323pin
Copy link
Contributor Author

0323pin commented Sep 20, 2024

Cheers!
I'll shift to your repository sometime during the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants