debian: gracefully handle failed wget when downloading FPGA/firmware images (#454) #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If wget fails, it's clobbering the FPGA/firmware storage in /usr/share/Nuand/bladeRF, leading to terrible results. Download to a temp file, then copy that if wget was successful. An MITM where a trusted proxy is frobulating HTTPS is still possible; checking the md5sum again is probably a great idea.
Don't overwrite the existing file if the new file fails the md5sum test.
jynik
added a commit
that referenced
this pull request
Feb 14, 2016
debian: gracefully handle failed wget when downloading FPGA/firmware images (#454)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revises the postinst scripts to be more careful about leaving broken stuff in /usr/share/Nuand/bladeRF.
Also improve commonality between the scripts...