This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Github uri formats can vary #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 1, 2019 11:03
Github uri formats can vary Fix issue that prevented a fork being used due to presence/absence of trailing slash
|
This issue was probably introduced at #637 |
|
Needs test with variations on urls in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github uri formats can vary. not just
.giton the end but also trailing slash.This issue that prevented a fork being used due to presence/absence of trailing slash and therefor string mismatch.
Extracted the code that normalises them into
GithubHelpers. Call it in 1 more place where the format can vary.Use
Urinotstringa bit more.More details in the message when it does not match. The original message doesn't say which of the 2 possible reasons it failed for, not pushable, or not matching. it just said
User 'anthony-steele' fork of 'helper-lib' exists but is unsuitable.