Use App Data Microsoft.DotNet.Sdk.Root for resolving SDK root - #7562
Merged
Merged
Conversation
nkolev92
approved these changes
Jul 13, 2026
zivkan
approved these changes
Jul 13, 2026
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14980
Description
NuGet.Packaging locates the SDK-provided trusted-root bundles ( trustedroots/codesignctl.pem and trustedroots/timestampctl.pem ) via AppContext.BaseDirectory , assuming it resolves to the versioned SDK directory (e.g. dotnet/sdk/10.0.301 ).
Under the Native AOT dotnet CLI, that assumption breaks:
dotnet-aot.dllis loaded directly by the muxer so the pem bundles can't be found and signature/timestamp verification could fail.This adopts the resolution pattern from dotnet/sdk#55110: the AOT entry point publishes the resolved versioned SDK directory as the
Microsoft.DotNet.Sdk.RootAppContext value.FallbackCertificateBundleX509ChainFactorynow reads that value first, falling back toAppContext.BaseDirectorywhen it is unsetPR Checklist