Skip to content

Make virtual project builder parameter required in MSBuildAPIUtility #7233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nkolev92 merged 1 commit into from
Mar 26, 2026
Merged

Make virtual project builder parameter required in MSBuildAPIUtility #7233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/NuGet.Core/NuGet.CommandLine.XPlat/Utility/MSBuildAPIUtility.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ internal class MSBuildAPIUtility

public IVirtualProjectBuilder VirtualProjectBuilder { get; }

public MSBuildAPIUtility(ILogger logger, IVirtualProjectBuilder virtualProjectBuilder = null)
public MSBuildAPIUtility(ILogger logger, IVirtualProjectBuilder virtualProjectBuilder)
{
Logger = logger ?? throw new ArgumentNullException(nameof(logger));
VirtualProjectBuilder = virtualProjectBuilder;
Expand Down
2 changes: 1 addition & 1 deletion ...sts/NuGet.XPlat.FuncTest/Commands/Package/Update/PackageUpdateIOTests/CommitAsyncTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public class CommitAsyncTests
{
private static PackageUpdateIO CreatePackageUpdateIO(string solutionRoot)
{
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance);
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance, virtualProjectBuilder: null);
var packageUpdateIO = new PackageUpdateIO(solutionRoot, msbuildUtility, TestEnvironmentVariableReader.EmptyInstance);
return packageUpdateIO;
}
Expand Down
2 changes: 1 addition & 1 deletion ...Plat.FuncTest/Commands/Package/Update/PackageUpdateIOTests/GetDependencyGraphSpecTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class GetDependencyGraphSpecTests
{
private static PackageUpdateIO CreatePackageUpdateIO(string solutionRoot)
{
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance);
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance, virtualProjectBuilder: null);
var packageUpdateIO = new PackageUpdateIO(solutionRoot, msbuildUtility, TestEnvironmentVariableReader.EmptyInstance);
return packageUpdateIO;
}
Expand Down
2 changes: 1 addition & 1 deletion ...uncTest/Commands/Package/Update/PackageUpdateIOTests/GetKnownVulnerabilitiesAsyncTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class GetKnownVulnerabilitiesAsyncTests
{
private static PackageUpdateIO CreatePackageUpdateIO(string solutionRoot)
{
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance);
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance, virtualProjectBuilder: null);
var packageUpdateIO = new PackageUpdateIO(solutionRoot, msbuildUtility, TestEnvironmentVariableReader.EmptyInstance);
return packageUpdateIO;
}
Expand Down
2 changes: 1 addition & 1 deletion ...XPlat.FuncTest/Commands/Package/Update/PackageUpdateIOTests/GetLatestVersionAsyncTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class GetLatestVersionAsyncTests
{
private static PackageUpdateIO CreatePackageUpdateIO(string solutionRoot)
{
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance);
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance, virtualProjectBuilder: null);
var packageUpdateIO = new PackageUpdateIO(solutionRoot, msbuildUtility, TestEnvironmentVariableReader.EmptyInstance);
return packageUpdateIO;
}
Expand Down
2 changes: 1 addition & 1 deletion ...XPlat.FuncTest/Commands/Package/Update/PackageUpdateIOTests/GetNonVulnerableAsyncTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class GetNonVulnerableAsyncTests
{
private static PackageUpdateIO CreatePackageUpdateIO(string solutionRoot)
{
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance);
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance, virtualProjectBuilder: null);
var packageUpdateIO = new PackageUpdateIO(solutionRoot, msbuildUtility, TestEnvironmentVariableReader.EmptyInstance);
return packageUpdateIO;
}
Expand Down
2 changes: 1 addition & 1 deletion ...lat.FuncTest/Commands/Package/Update/PackageUpdateIOTests/GetPackageSourceMappingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class GetPackageSourceMappingTests
{
private static PackageUpdateIO CreatePackageUpdateIO(string solutionRoot)
{
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance);
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance, virtualProjectBuilder: null);
var packageUpdateIO = new PackageUpdateIO(solutionRoot, msbuildUtility, TestEnvironmentVariableReader.EmptyInstance);
return packageUpdateIO;
}
Expand Down
2 changes: 1 addition & 1 deletion ...t.FuncTest/Commands/Package/Update/PackageUpdateIOTests/GetProjectAssetsFileAsyncTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public class GetProjectAssetsFileAsyncTests
{
private static PackageUpdateIO CreatePackageUpdateIO(string solutionRoot)
{
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance);
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance, virtualProjectBuilder: null);
var packageUpdateIO = new PackageUpdateIO(solutionRoot, msbuildUtility, TestEnvironmentVariableReader.EmptyInstance);
return packageUpdateIO;
}
Expand Down
2 changes: 1 addition & 1 deletion ...t/Commands/Package/Update/PackageUpdateIOTests/PreviewUpdatePackageReferenceAsyncTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class PreviewUpdatePackageReferenceAsyncTests
{
private static PackageUpdateIO CreatePackageUpdateIO(string solutionRoot)
{
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance);
var msbuildUtility = new MSBuildAPIUtility(NullLogger.Instance, virtualProjectBuilder: null);
var packageUpdateIO = new PackageUpdateIO(solutionRoot, msbuildUtility, TestEnvironmentVariableReader.EmptyInstance);
return packageUpdateIO;
}
Expand Down
10 changes: 5 additions & 5 deletions test/NuGet.Core.FuncTests/NuGet.XPlat.FuncTest/ListPackageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ await SimpleTestPackageUtility.CreatePackagesAsync(
using TextWriter consoleOut = new StringWriter(output);
using TextWriter consoleError = new StringWriter(error);
var logger = new TestLogger(_testOutputHelper);
ListPackageCommandRunner listPackageCommandRunner = new(new MSBuildAPIUtility(logger));
ListPackageCommandRunner listPackageCommandRunner = new(new MSBuildAPIUtility(logger, virtualProjectBuilder: null));
var packageRefArgs = new ListPackageArgs(
path: Path.Combine(pathContext.SolutionRoot, "solution.sln"),
packageSources: [new(mockServer.ServiceIndexUri)],
Expand Down Expand Up @@ -333,7 +333,7 @@ await SimpleTestPackageUtility.CreatePackagesAsync(
using TextWriter consoleOut = new StringWriter(output);
using TextWriter consoleError = new StringWriter(error);
var logger = new TestLogger(_testOutputHelper);
ListPackageCommandRunner listPackageCommandRunner = new(new MSBuildAPIUtility(logger));
ListPackageCommandRunner listPackageCommandRunner = new(new MSBuildAPIUtility(logger, virtualProjectBuilder: null));
var packageRefArgs = new ListPackageArgs(
path: solution.SolutionPath,
packageSources: [new PackageSource(pathContext.PackageSource)],
Expand Down Expand Up @@ -428,7 +428,7 @@ public async Task GetReportDataAsync_WhenReportTypeIsVulnerable_ShouldUseAuditSo
CancellationToken.None
);

var listPackageCommandRunner = new ListPackageCommandRunner(new MSBuildAPIUtility(mockLogger.Object));
var listPackageCommandRunner = new ListPackageCommandRunner(new MSBuildAPIUtility(mockLogger.Object, virtualProjectBuilder: null));


// Act
Expand Down Expand Up @@ -474,7 +474,7 @@ public async Task GetReportDataAsync_WithSolutionFilePassed_ShouldList()
CancellationToken.None
);

var listPackageCommandRunner = new ListPackageCommandRunner(new MSBuildAPIUtility(mockLogger.Object));
var listPackageCommandRunner = new ListPackageCommandRunner(new MSBuildAPIUtility(mockLogger.Object, virtualProjectBuilder: null));

// Act
var result = await listPackageCommandRunner.GetReportDataAsync(listPackageArgs);
Expand Down Expand Up @@ -529,7 +529,7 @@ public async Task GetReportDataAsync_WhenReportTypeIsVulnerableAuditSourcesWithN
CancellationToken.None
);

var listPackageCommandRunner = new ListPackageCommandRunner(new MSBuildAPIUtility(mockLogger.Object));
var listPackageCommandRunner = new ListPackageCommandRunner(new MSBuildAPIUtility(mockLogger.Object, virtualProjectBuilder: null));

// Act
var result = await listPackageCommandRunner.GetReportDataAsync(listPackageArgs);
Expand Down
Loading
Loading