Skip to content

[7.0.x] dotnet nuget why: write target package in graph#6990

Merged
zivkan merged 1 commit intorelease/7.0.xfrom
dev-zivkan-7.0.x-why-formatting
Dec 5, 2025
Merged

[7.0.x] dotnet nuget why: write target package in graph#6990
zivkan merged 1 commit intorelease/7.0.xfrom
dev-zivkan-7.0.x-why-formatting

Conversation

@zivkan
Copy link
Member

@zivkan zivkan commented Dec 4, 2025

Bug

Fixes: NuGet/Home#14664

Description

Cherry-pick #6975 to the release/7.0.x branch

But without some of the nullable changes, to reduce risk that it could introduce nullable warnings/errors when the dotnet/sdk repo uses it.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

.NET approval template:

Customer Impact

Impacts customers using the dotnet nuget why command. 9.0.300 displays a package dependency graph using line characters, with the package names on the same line as the line. 10.0.100 puts the package ID searched for on a new line. There are screenshots in this issue: NuGet/Home#14664

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Justification: The existing code to draw the package graph was replaced with Spectre.Console.

Addtionally, while another team had already caused Spectre.Console to be included in the upcoming 10.0.200 SDK, it's not currently part of the 10.0.100 SDK. I did validate with the source build team that adding it to 10.0.1xx servicing is acceptable from their point of view

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

I'm not sure what exactly is meant by "packaging changes", but as mentioned above, it will cause Spectre.Console.dll to ship in the SDK, which it did not before.

@zivkan zivkan requested a review from a team as a code owner December 4, 2025 23:53
@zivkan zivkan requested review from jeffkl and nkolev92 December 4, 2025 23:53
@zivkan zivkan merged commit fa2dec9 into release/7.0.x Dec 5, 2025
17 of 18 checks passed
@zivkan zivkan deleted the dev-zivkan-7.0.x-why-formatting branch December 5, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants