Skip to content

Fix up telemetry for package pruning, .NET Framework is no longer enabled by default #6845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2025
Merged

Fix up telemetry for package pruning, .NET Framework is no longer enabled by default #6845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56629cc
Fix up telemetry for package pruning, .NET Framework is no longer ena…
nkolev92 Oct 8, 2025
7a95040
address feedback, add more
nkolev92 Oct 8, 2025
3e65236
format
nkolev92 Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/NuGet.Core/NuGet.Commands/RestoreCommand/RestoreCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,13 +409,10 @@ internal static void PopulatePruningEnabledTelemetry(PackageSpec project, Teleme
{
bool isPruningEnabled = framework.PackagesToPrune.Count > 0;
bool isNetCoreAppFramework = StringComparer.OrdinalIgnoreCase.Equals(framework.FrameworkName.Framework, FrameworkConstants.FrameworkIdentifiers.NetCoreApp);
// All .NETCoreApp, .NET Standard >= 2.0 , and .NET Framework >= 4.6.1 projects are compatible with package pruning.
bool isPruningCompatibleFramework = isNetCoreAppFramework ||
// .NETCoreApp >= 2.0, .NET Standard >= 2.0 are compatible with package pruning.
bool isPruningCompatibleFramework = (isNetCoreAppFramework && framework.FrameworkName.Version.Major >= 2) ||
(StringComparer.OrdinalIgnoreCase.Equals(framework.FrameworkName.Framework, FrameworkConstants.FrameworkIdentifiers.NetStandard) &&
framework.FrameworkName.Version.Major >= 2) ||
(project.RestoreMetadata.UsingMicrosoftNETSdk &&
StringComparer.OrdinalIgnoreCase.Equals(framework.FrameworkName.Framework, FrameworkConstants.FrameworkIdentifiers.Net) &&
framework.FrameworkName.Version >= FrameworkConstants.CommonFrameworks.Net461.Version);
framework.FrameworkName.Version.Major >= 2);

pruningDefault |= isNetCoreAppFramework && framework.FrameworkName.Version.Major >= 10;

Expand Down
10 changes: 9 additions & 1 deletion test/NuGet.Core.FuncTests/NuGet.Commands.FuncTest/RestoreCommand_PrunePackageReference.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2679,6 +2679,14 @@ public void PopulatePruningEnabledTelemetry_WithPruningDisabledByDefault_AndVari
},
}
},
""net9.0"": {
""dependencies"": {
""A"": {
""version"": ""[1.0.0,)"",
""target"": ""Package"",
},
}
},
}
}";

Expand All @@ -2692,7 +2700,7 @@ public void PopulatePruningEnabledTelemetry_WithPruningDisabledByDefault_AndVari
RestoreCommand.PopulatePruningEnabledTelemetry(projectSpec, testEvent);
testEvent["Pruning.FrameworksEnabled.Count"].Should().Be(1);
testEvent["Pruning.DefaultEnabled"].Should().Be(false);
testEvent["Pruning.FrameworksUnsupported.Count"].Should().Be(1);
testEvent["Pruning.FrameworksUnsupported.Count"].Should().Be(2);
testEvent["Pruning.FrameworksDisabled.Count"].Should().Be(1);
}

Expand Down
4 changes: 2 additions & 2 deletions test/NuGet.Core.Tests/NuGet.Commands.Test/RestoreCommandTests/RestoreCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3104,8 +3104,8 @@ await SimpleTestPackageUtility.CreateFolderFeedV3Async(
projectInformationEvent["UpdatedMSBuildFiles"].Should().Be(false);
projectInformationEvent["NETSdkVersion"].Should().Be(NuGetVersion.Parse("10.0.100"));
projectInformationEvent["Pruning.FrameworksEnabled.Count"].Should().Be(0);
projectInformationEvent["Pruning.FrameworksDisabled.Count"].Should().Be(1);
projectInformationEvent["Pruning.FrameworksUnsupported.Count"].Should().Be(0);
projectInformationEvent["Pruning.FrameworksDisabled.Count"].Should().Be(0);
projectInformationEvent["Pruning.FrameworksUnsupported.Count"].Should().Be(1);
projectInformationEvent["Pruning.DefaultEnabled"].Should().Be(false);
projectInformationEvent["UsesLegacyPackagesDirectory"].Should().Be(false);
}
Expand Down