Rename _RestorePackagePruningDefault to RestorePackagePruningDefault #6753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aortiz-msft
approved these changes
Sep 2, 2025
jeffkl
approved these changes
Sep 2, 2025
zivkan
approved these changes
Sep 2, 2025
Member
zivkan
left a comment
zivkan
left a comment
There was a problem hiding this comment.
I think the PR description could be a bit more clear in explicitly saying it's Visual Studio's CPS doing the caching, especially for people who don't know what "DTB" means. Otherwise, I'm happy that this is fixed, after I spent far too many hours last week trying to investigate such bizarre behavior.
Member
Author
|
Thanks for the suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14511
Description
_RestorePackagePruningDefault is not cached by CPS and leads to extra design time builds when the project is loaded from the cache.
The
_here just clarifies that customers shouldn't use this property, but there's really no true benefit to it, since it's convention anyways, it's not like MSBuild enforces it.PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.