Remove some allocations under HttpFileSystemBasedFindPackageByIdResource.ConsumeFlatContainerIndexAsync #6265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce.ConsumeFlatContainerIndexAsync
microsoft-github-policy-service
bot
added
the
Community
ToddGrun
commented
Feb 11, 2025
| var normalizedVersionString = Identity.Version.ToNormalizedString(); | ||
| string idInLowerCase = Id.ToLowerInvariant(); | ||
|
|
||
| var builder = StringBuilderPool.Shared.Rent(256); |
There was a problem hiding this comment.
Roughly 50% of the string builders used in this codepath end up exceeding the 256 char limit, and thus aren't released back to the pool. I didn't address it in this PR, as delay calculating this ends up getting rid of the vast majority of the work, but it might be worth considering upping that 256 char limit used in StringBuilderPool.
ToddGrun
commented
Feb 11, 2025
| /// This struct is used to read over a memory stream in parts, in order to avoid reading the entire stream into memory. | ||
| /// It functions as a wrapper around <see cref="Utf8JsonStreamReader"/>, while maintaining a stream and a buffer to read from. | ||
| /// </summary> | ||
| internal ref struct Utf8JsonStreamReader |
|
Test insertion based on commit 1 to get speedometer numbers: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/610228 |
microsoft-github-policy-service
bot
added
the
Status:No recent activity
jeffkl
removed
the
Status:No recent activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
NuGet/Home#14095
Fixes:
Reduces allocation in this codepath
Description
Swtiched to using Utf8JsonStreamReader instead of newtonsoft for reading some json. However, this class wasn't available from what I could determine, so I took the easy route of just duplicating the code. This isn't great, and I'd love guidance on a better way to access this.
Changed PackageInfo.ContentUri to be calculated on a deferred basis as it's very expensive to calculate and is used quite infrequently (I saw about 0.1% of PackageInfo objects created actually get queried for that data)
PR Checklist