Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary source-build patch #5414

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

MichaelSimons
Copy link
Contributor

@MichaelSimons MichaelSimons commented Sep 20, 2023

Bug

Fixes: dotnet/source-build#3149

Regression? Last working version: N/A

Description

This source-build patch is no longer necessary as it was a workaround for an arcade issue that has since been addressed - dotnet/arcade#7549

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@MichaelSimons MichaelSimons requested a review from a team as a code owner September 20, 2023 17:47
@ghost ghost added the Community PRs created by someone not in the NuGet team label Sep 20, 2023
@MichaelSimons
Copy link
Contributor Author

@nkolev92 - This is needed for .NET 8.0, will change made in the dev branch flow into .NET 8.0? TIA

@nkolev92
Copy link
Member

@nkolev92 - This is needed for .NET 8.0, will change made in the dev branch flow into .NET 8.0? TIA

Yep, dev is still targeting NET8.0.

cc @aortiz-msft to add a Merge this release label. This is just infrastructure.

@aortiz-msft aortiz-msft merged commit 1a85afa into NuGet:dev Sep 20, 2023
15 checks passed
@nkolev92
Copy link
Member

@MichaelSimons
Copy link
Contributor Author

The source build leg failed, https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8423365&view=logs&j=cb98efd6-7062-56ef-f642-0176540bbe0a, is that expected @MichaelSimons

No it wasn't intentional. Looks like I needed to update the arcade version as well as it is old and missing the fix I referenced earlier. Will open another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VMR] nuget-client build fails on case-preserving filesystems (Mac, Windows)
3 participants