Skip to content

Use "-Channel x.0 -Quality Daily" option with dotnet-install for configure.ps1 #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erdembayar merged 5 commits into from
Oct 1, 2021
Merged

Use "-Channel x.0 -Quality Daily" option with dotnet-install for configure.ps1 #4289

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
217f4c1
Add -Quality Daily into dotnet-install.ps1 parameters
erdembayar Sep 28, 2021
1c2b57c
Remove -Quality Daily from Channel 2.2 for dotnet-install.ps1
erdembayar Sep 28, 2021
4dc172c
Use channel main version.
erdembayar Sep 29, 2021
ac9b29b
Fail if unable to detect channel version.
erdembayar Sep 29, 2021
d0c2437
Clean up.
erdembayar Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions build/common.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,22 @@ Function Install-DotnetCLI {

#If "-force" is specified, or folder with specific version doesn't exist, the download command will run"
if ($Force -or -not (Test-Path $probeDotnetPath)) {
Trace-Log "$DotNetInstall -Channel $($cli.Channel) -InstallDir $($cli.Root) -Version $($cli.Version) -Architecture $arch -NoPath"
& $DotNetInstall -Channel $cli.Channel -InstallDir $cli.Root -Version $cli.Version -Architecture $arch -NoPath
$channelMainVersion = ""
foreach($channelPart in $cli.Channel.Split('/'))
{
if ($channelPart -match "\d+.*")
{
$channelMainVersion = $channelPart.Split('.')[0]
Break
}
}

if ([string]::IsNullOrEmpty($channelMainVersion)) {
Error-Log "Unable to detect channel version for dotnetinstall.ps1. The CLI install cannot be initiated." -Fatal
}

Trace-Log "$DotNetInstall -Channel $($channelMainVersion) -Quality Daily -InstallDir $($cli.Root) -Version $($cli.Version) -Architecture $arch -NoPath"
& $DotNetInstall -Channel $channelMainVersion -Quality Daily -InstallDir $cli.Root -Version $cli.Version -Architecture $arch -NoPath
}

if (-not (Test-Path $DotNetExe)) {
Expand Down