Skip to content

No longer use UI Filter starting from Installed tab#3881

Merged
donnie-msft merged 1 commit intodevfrom
dev-donnie-msft-uiFilterDisableInstalled
Feb 1, 2021
Merged

No longer use UI Filter starting from Installed tab#3881
donnie-msft merged 1 commit intodevfrom
dev-donnie-msft-uiFilterDisableInstalled

Conversation

@donnie-msft
Copy link
Contributor

@donnie-msft donnie-msft commented Feb 1, 2021

Fixes: NuGet/Home#10510

Regression? Last working version: Yes, 16.9 regression

Description

For a bug fix (#3864) I switched back to passing the Version property in the Updates tab. However, if Installed tab is loaded first, then a UI filter is applied, Version will not bet set to "Latest Version", so it results in an incorrect or broken update action.

This PR takes the simplest approach for 16.9 and no longer uses the first-load of Installed data as a perf improvement for Updates tab.

UI Filter Scenarios:

  • Updates tab loaded first, switch to Installed tab.
  • Installed tab loaded first, switch to Updates tab. (this PR disables)
  • After both Installed/Updates have loaded once, switching between them repetitively.

The expected Error is shown, when opening PMUI to Installed tab, switching to Updates tab, then performing an Update all:
image

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@nkolev92 nkolev92 requested a review from a team February 1, 2021 20:21
Copy link
Contributor

@dtivel dtivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking through this change with @donnie-msft, this change makes sense; however, it's an unintuitive change. Naively, I initially guessed that reverting the LatestVersion -> Version change (see the original issue) would be the fix, but Version already means different things to different tabs. Should we update comments on those properties to explain this?

Furthermore, I wouldn't expect that the Installed tab displaying first is crucial to reproducing this Updates tab bug. There is a UI test hole here which we should look at fixing after 16.9. (Thanks for creating NuGet/Home#10514.)

@donnie-msft donnie-msft merged commit 24d1baf into dev Feb 1, 2021
@donnie-msft donnie-msft deleted the dev-donnie-msft-uiFilterDisableInstalled branch February 1, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PM UI: cannot bulk update packages

2 participants