No longer use UI Filter starting from Installed tab#3881
Merged
donnie-msft merged 1 commit intodevfrom Feb 1, 2021
Merged
Conversation
dtivel
approved these changes
Feb 1, 2021
Contributor
dtivel
left a comment
There was a problem hiding this comment.
After talking through this change with @donnie-msft, this change makes sense; however, it's an unintuitive change. Naively, I initially guessed that reverting the LatestVersion -> Version change (see the original issue) would be the fix, but Version already means different things to different tabs. Should we update comments on those properties to explain this?
Furthermore, I wouldn't expect that the Installed tab displaying first is crucial to reproducing this Updates tab bug. There is a UI test hole here which we should look at fixing after 16.9. (Thanks for creating NuGet/Home#10514.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: NuGet/Home#10510
Regression? Last working version: Yes, 16.9 regression
Description
For a bug fix (#3864) I switched back to passing the
Versionproperty in the Updates tab. However, if Installed tab is loaded first, then a UI filter is applied,Versionwill not bet set to "Latest Version", so it results in an incorrect or broken update action.This PR takes the simplest approach for 16.9 and no longer uses the first-load of Installed data as a perf improvement for Updates tab.
UI Filter Scenarios:
Installed tab loaded first, switch to Updates tab.(this PR disables)The expected Error is shown, when opening PMUI to Installed tab, switching to Updates tab, then performing an Update all:

PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation