Remove IncludeSymbols=true from common.targets #3758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkan
approved these changes
Nov 10, 2020
zkat
approved these changes
Nov 10, 2020
Member
|
Sounds like this is a workaround for a product bug. |
Member
|
the product bug is linked in the PR comment: NuGet/Home#10249 |
Member
|
Welp :D |
heng-liu
force-pushed
the
dev-hengliu-CI-remove-IncludeSymbols
branch
from
15dad58 to
461efb1
Compare
heng-liu
force-pushed
the
dev-hengliu-CI-remove-IncludeSymbols
branch
from
461efb1 to
38e5a72
Compare
zivkan
pushed a commit
that referenced
this pull request
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/547
Regression: No
Fix
Details: Remove IncludeSymbols=true from common.targets, as the symbol packages are not used.
NuGet/Home#10249 also caused a problem if specifying IncludeSymbols=true. It won't fail the pack even if the packing on nupkg failed.
Testing/Validation
Tests Added: No
Reason for not adding tests:
Validation: